You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2022/02/04 18:32:59 UTC
svn commit: r1897774 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java
Author: tilman
Date: Fri Feb 4 18:32:59 2022
New Revision: 1897774
URL: http://svn.apache.org/viewvc?rev=1897774&view=rev
Log:
PDFBOX-4892: optimize, as suggested by valerybokov
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java?rev=1897774&r1=1897773&r2=1897774&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java Fri Feb 4 18:32:59 2022
@@ -806,17 +806,18 @@ class AppearanceGeneratorHelper
float yTextPos = contentRect.getUpperRightY();
int topIndex = ((PDListBox) field).getTopIndex();
+ float ascent = font.getFontDescriptor().getAscent();
+ float height = font.getBoundingBox().getHeight();
for (int i = topIndex; i < numOptions; i++)
{
-
if (i == topIndex)
{
- yTextPos = yTextPos - font.getFontDescriptor().getAscent() / FONTSCALE * fontSize;
+ yTextPos = yTextPos - ascent / FONTSCALE * fontSize;
}
else
{
- yTextPos = yTextPos - font.getBoundingBox().getHeight() / FONTSCALE * fontSize;
+ yTextPos = yTextPos - height / FONTSCALE * fontSize;
contents.beginText();
}