You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "reuvenlax (via GitHub)" <gi...@apache.org> on 2025/02/12 20:25:09 UTC
[PR] Fix timestamp propagation to successful-loads PCollection. [beam]
reuvenlax opened a new pull request, #33973:
URL: https://github.com/apache/beam/pull/33973
R: @slilichenko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix timestamp propagation to successful-loads PCollection. [beam]
Posted by "reuvenlax (via GitHub)" <gi...@apache.org>.
reuvenlax commented on code in PR #33973:
URL: https://github.com/apache/beam/pull/33973#discussion_r1953372991
##########
runners/jet/src/main/java/org/apache/beam/runners/jet/metrics/JetMetricsContainer.java:
##########
Review Comment:
Removed. I think spotlessApply created this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix timestamp propagation to successful-loads PCollection. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33973:
URL: https://github.com/apache/beam/pull/33973#issuecomment-2654893224
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damondouglas for label java.
R: @shunping for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix timestamp propagation to successful-loads PCollection. [beam]
Posted by "reuvenlax (via GitHub)" <gi...@apache.org>.
reuvenlax commented on code in PR #33973:
URL: https://github.com/apache/beam/pull/33973#discussion_r1953378966
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BatchLoads.java:
##########
Review Comment:
Shouldn't be necessary. dynamic sharding uses GroupIntoBatches, which explicitly handles the min timestamp case (it's a stateful DoFn).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix timestamp propagation to successful-loads PCollection. [beam]
Posted by "reuvenlax (via GitHub)" <gi...@apache.org>.
reuvenlax merged PR #33973:
URL: https://github.com/apache/beam/pull/33973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix timestamp propagation to successful-loads PCollection. [beam]
Posted by "slilichenko (via GitHub)" <gi...@apache.org>.
slilichenko commented on code in PR #33973:
URL: https://github.com/apache/beam/pull/33973#discussion_r1953354409
##########
runners/jet/src/main/java/org/apache/beam/runners/jet/metrics/JetMetricsContainer.java:
##########
Review Comment:
Did you mean to modify this file? Looks like it's a no-op change.
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BatchLoads.java:
##########
Review Comment:
Do you need to add the same logic in case of dynamic sharding?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org