You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/11/01 18:03:16 UTC
[GitHub] [solr] justinrsweeney opened a new pull request, #1157: Modifying github actions to run on all branches including ones with slashes
justinrsweeney opened a new pull request, #1157:
URL: https://github.com/apache/solr/pull/1157
https://issues.apache.org/jira/browse/SOLR-16516
# Description
This change modifies the Github Actions to execute on any PR opened against any branch, including branches with a `/` in the branch name. This can be useful for organizations that have forked the Solr repo and want to run checks against additional branches.
# Solution
This is a simple change to the pattern used to be `**` instead of `*` to include branches with slashes. More info here: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet.
# Tests
N/A
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] justinrsweeney commented on pull request #1157: Modifying github actions to run on all branches including ones with slashes
Posted by GitBox <gi...@apache.org>.
justinrsweeney commented on PR #1157:
URL: https://github.com/apache/solr/pull/1157#issuecomment-1329354130
@risdenk Thanks for approving, is this something we could merge into main and also backport to branch_9x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1157: Modifying github actions to run on all branches including ones with slashes
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1157:
URL: https://github.com/apache/solr/pull/1157#issuecomment-1329509900
@justinrsweeney yup merged to main and will backport to branch_9x shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] magibney commented on pull request #1157: Modifying github actions to run on all branches including ones with slashes
Posted by GitBox <gi...@apache.org>.
magibney commented on PR #1157:
URL: https://github.com/apache/solr/pull/1157#issuecomment-1302223617
This makes sense to me; seems like maybe just an oversight rather than an intentional decision. @anshumg could you take a quick look and confirm/contradict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1157: Modifying github actions to run on all branches including ones with slashes
Posted by GitBox <gi...@apache.org>.
risdenk merged PR #1157:
URL: https://github.com/apache/solr/pull/1157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1157: Modifying github actions to run on all branches including ones with slashes
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1157:
URL: https://github.com/apache/solr/pull/1157#issuecomment-1329531038
backported to branch_9x as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org