You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@edgent.apache.org by Christofer Dutz <ch...@c-ware.de> on 2018/03/04 12:35:45 UTC

Re: Can I Contribute a RabbitMQ connector?

Hi Vinoyang,

I had a look at your pull-requests (well the gitignore one is quite trivial and hence very easy to review ;)) 

There was one thing that I wanted to double-check, but the used RabitMQ client library is triple licensed, one of them being Apache 2.0, so that's perfect.

Unfortunately I'm not yet that deep into the details of Edgent, so I would like to ask Dale or someone who knows the inner workings a little more than me to re-check and do the merge.

Chris

 

Am 26.02.18, 07:22 schrieb "vino yang" <ya...@gmail.com>:

    Hi christofer.dutz:
    
    Thanks for your reply! I will do this task.
    
    vinoyang
    
    2018-02-26 14:16 GMT+08:00 Christofer Dutz <ch...@c-ware.de>:
    
    > Sorry,
    >
    > I was traveling yesterday and sick the days before.
    > Well I did have a look and I do agree that a rabbitmq connector could be a
    > valuable addition. As long as the needed libraries have Apache compatible
    > licensees.
    >
    > Chris
    >
    > Outlook for Android<https://aka.ms/ghei36> herunterladen
    >
    > ________________________________
    > From: vino yang <ya...@gmail.com>
    > Sent: Monday, February 26, 2018 4:36:23 AM
    > To: dev@edgent.apache.org
    > Subject: Re: Can I Contribute a RabbitMQ connector?
    >
    > No one can give some comment?
    >
    > 2018-02-25 15:39 GMT+08:00 vino yang <ya...@gmail.com>:
    >
    > > Hi :
    > > I find there is no one RabbitMQ connector for edgent. I want to
    > contribute
    > > a RabbitMQ connector. How about this idea? Is there someone working for
    > > this?
    > >
    > > Thanks!
    > > vinoyang
    > >
    >
    


Re: Can I Contribute a RabbitMQ connector?

Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Vino,

well I had to do a bit of tweaking as the connector was not added to the distribution. Also it was missing Java7 and Android versions.
I added all of that and merged all after the test-suite was green.

However as I do not use RabbitMQ, I haven't tested the connector for real.

Thanks for contributing (

Chris



Am 11.03.18, 11:04 schrieb "Christofer Dutz" <ch...@c-ware.de>:

    Hi Vino,
    
    sorry for no one stepping up ... I've never merged Edgent PRs yet, but this is a good time to step up and do it.
    I'll keep you posted on my progress.
    
    Chris
    
    Am 11.03.18, 08:16 schrieb "vino yang" <ya...@gmail.com>:
    
        Hi Christofer Dutz,
        
        Is there any progress about this issue?
        
        vino yang
        Thanks.
        
        
        2018-03-05 9:33 GMT+08:00 vino yang <ya...@gmail.com>:
        
        > Hi Christofer Dutz,
        >
        > That's all right. I think the RabbitMQ's licenses would not be a problem.
        > There are many open source systems and libraries which have integrated with
        > it.
        >
        > RabbitMQ can support the MQTT with adapter (plugin), it would be good for
        > the IoT devices. More detail : http://www.rabbitmq.com/mqtt.html
        >
        > I hope the connector would be added to edgent to enhance it's
        > connectivity.
        >
        > vinoyang
        > Thanks.
        >
        > 2018-03-04 20:35 GMT+08:00 Christofer Dutz <ch...@c-ware.de>:
        >
        >> Hi Vinoyang,
        >>
        >> I had a look at your pull-requests (well the gitignore one is quite
        >> trivial and hence very easy to review ;))
        >>
        >> There was one thing that I wanted to double-check, but the used RabitMQ
        >> client library is triple licensed, one of them being Apache 2.0, so that's
        >> perfect.
        >>
        >> Unfortunately I'm not yet that deep into the details of Edgent, so I
        >> would like to ask Dale or someone who knows the inner workings a little
        >> more than me to re-check and do the merge.
        >>
        >> Chris
        >>
        >>
        >>
        >> Am 26.02.18, 07:22 schrieb "vino yang" <ya...@gmail.com>:
        >>
        >>     Hi christofer.dutz:
        >>
        >>     Thanks for your reply! I will do this task.
        >>
        >>     vinoyang
        >>
        >>     2018-02-26 14:16 GMT+08:00 Christofer Dutz <christofer.dutz@c-ware.de
        >> >:
        >>
        >>     > Sorry,
        >>     >
        >>     > I was traveling yesterday and sick the days before.
        >>     > Well I did have a look and I do agree that a rabbitmq connector
        >> could be a
        >>     > valuable addition. As long as the needed libraries have Apache
        >> compatible
        >>     > licensees.
        >>     >
        >>     > Chris
        >>     >
        >>     > Outlook for Android<https://aka.ms/ghei36> herunterladen
        >>     >
        >>     > ________________________________
        >>     > From: vino yang <ya...@gmail.com>
        >>     > Sent: Monday, February 26, 2018 4:36:23 AM
        >>     > To: dev@edgent.apache.org
        >>     > Subject: Re: Can I Contribute a RabbitMQ connector?
        >>     >
        >>     > No one can give some comment?
        >>     >
        >>     > 2018-02-25 15:39 GMT+08:00 vino yang <ya...@gmail.com>:
        >>     >
        >>     > > Hi :
        >>     > > I find there is no one RabbitMQ connector for edgent. I want to
        >>     > contribute
        >>     > > a RabbitMQ connector. How about this idea? Is there someone
        >> working for
        >>     > > this?
        >>     > >
        >>     > > Thanks!
        >>     > > vinoyang
        >>     > >
        >>     >
        >>
        >>
        >>
        >
        
    
    


Re: Can I Contribute a RabbitMQ connector?

Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Vino,

sorry for no one stepping up ... I've never merged Edgent PRs yet, but this is a good time to step up and do it.
I'll keep you posted on my progress.

Chris

Am 11.03.18, 08:16 schrieb "vino yang" <ya...@gmail.com>:

    Hi Christofer Dutz,
    
    Is there any progress about this issue?
    
    vino yang
    Thanks.
    
    
    2018-03-05 9:33 GMT+08:00 vino yang <ya...@gmail.com>:
    
    > Hi Christofer Dutz,
    >
    > That's all right. I think the RabbitMQ's licenses would not be a problem.
    > There are many open source systems and libraries which have integrated with
    > it.
    >
    > RabbitMQ can support the MQTT with adapter (plugin), it would be good for
    > the IoT devices. More detail : http://www.rabbitmq.com/mqtt.html
    >
    > I hope the connector would be added to edgent to enhance it's
    > connectivity.
    >
    > vinoyang
    > Thanks.
    >
    > 2018-03-04 20:35 GMT+08:00 Christofer Dutz <ch...@c-ware.de>:
    >
    >> Hi Vinoyang,
    >>
    >> I had a look at your pull-requests (well the gitignore one is quite
    >> trivial and hence very easy to review ;))
    >>
    >> There was one thing that I wanted to double-check, but the used RabitMQ
    >> client library is triple licensed, one of them being Apache 2.0, so that's
    >> perfect.
    >>
    >> Unfortunately I'm not yet that deep into the details of Edgent, so I
    >> would like to ask Dale or someone who knows the inner workings a little
    >> more than me to re-check and do the merge.
    >>
    >> Chris
    >>
    >>
    >>
    >> Am 26.02.18, 07:22 schrieb "vino yang" <ya...@gmail.com>:
    >>
    >>     Hi christofer.dutz:
    >>
    >>     Thanks for your reply! I will do this task.
    >>
    >>     vinoyang
    >>
    >>     2018-02-26 14:16 GMT+08:00 Christofer Dutz <christofer.dutz@c-ware.de
    >> >:
    >>
    >>     > Sorry,
    >>     >
    >>     > I was traveling yesterday and sick the days before.
    >>     > Well I did have a look and I do agree that a rabbitmq connector
    >> could be a
    >>     > valuable addition. As long as the needed libraries have Apache
    >> compatible
    >>     > licensees.
    >>     >
    >>     > Chris
    >>     >
    >>     > Outlook for Android<https://aka.ms/ghei36> herunterladen
    >>     >
    >>     > ________________________________
    >>     > From: vino yang <ya...@gmail.com>
    >>     > Sent: Monday, February 26, 2018 4:36:23 AM
    >>     > To: dev@edgent.apache.org
    >>     > Subject: Re: Can I Contribute a RabbitMQ connector?
    >>     >
    >>     > No one can give some comment?
    >>     >
    >>     > 2018-02-25 15:39 GMT+08:00 vino yang <ya...@gmail.com>:
    >>     >
    >>     > > Hi :
    >>     > > I find there is no one RabbitMQ connector for edgent. I want to
    >>     > contribute
    >>     > > a RabbitMQ connector. How about this idea? Is there someone
    >> working for
    >>     > > this?
    >>     > >
    >>     > > Thanks!
    >>     > > vinoyang
    >>     > >
    >>     >
    >>
    >>
    >>
    >
    


Re: Can I Contribute a RabbitMQ connector?

Posted by vino yang <ya...@gmail.com>.
Hi Christofer Dutz,

Is there any progress about this issue?

vino yang
Thanks.


2018-03-05 9:33 GMT+08:00 vino yang <ya...@gmail.com>:

> Hi Christofer Dutz,
>
> That's all right. I think the RabbitMQ's licenses would not be a problem.
> There are many open source systems and libraries which have integrated with
> it.
>
> RabbitMQ can support the MQTT with adapter (plugin), it would be good for
> the IoT devices. More detail : http://www.rabbitmq.com/mqtt.html
>
> I hope the connector would be added to edgent to enhance it's
> connectivity.
>
> vinoyang
> Thanks.
>
> 2018-03-04 20:35 GMT+08:00 Christofer Dutz <ch...@c-ware.de>:
>
>> Hi Vinoyang,
>>
>> I had a look at your pull-requests (well the gitignore one is quite
>> trivial and hence very easy to review ;))
>>
>> There was one thing that I wanted to double-check, but the used RabitMQ
>> client library is triple licensed, one of them being Apache 2.0, so that's
>> perfect.
>>
>> Unfortunately I'm not yet that deep into the details of Edgent, so I
>> would like to ask Dale or someone who knows the inner workings a little
>> more than me to re-check and do the merge.
>>
>> Chris
>>
>>
>>
>> Am 26.02.18, 07:22 schrieb "vino yang" <ya...@gmail.com>:
>>
>>     Hi christofer.dutz:
>>
>>     Thanks for your reply! I will do this task.
>>
>>     vinoyang
>>
>>     2018-02-26 14:16 GMT+08:00 Christofer Dutz <christofer.dutz@c-ware.de
>> >:
>>
>>     > Sorry,
>>     >
>>     > I was traveling yesterday and sick the days before.
>>     > Well I did have a look and I do agree that a rabbitmq connector
>> could be a
>>     > valuable addition. As long as the needed libraries have Apache
>> compatible
>>     > licensees.
>>     >
>>     > Chris
>>     >
>>     > Outlook for Android<https://aka.ms/ghei36> herunterladen
>>     >
>>     > ________________________________
>>     > From: vino yang <ya...@gmail.com>
>>     > Sent: Monday, February 26, 2018 4:36:23 AM
>>     > To: dev@edgent.apache.org
>>     > Subject: Re: Can I Contribute a RabbitMQ connector?
>>     >
>>     > No one can give some comment?
>>     >
>>     > 2018-02-25 15:39 GMT+08:00 vino yang <ya...@gmail.com>:
>>     >
>>     > > Hi :
>>     > > I find there is no one RabbitMQ connector for edgent. I want to
>>     > contribute
>>     > > a RabbitMQ connector. How about this idea? Is there someone
>> working for
>>     > > this?
>>     > >
>>     > > Thanks!
>>     > > vinoyang
>>     > >
>>     >
>>
>>
>>
>

Re: Can I Contribute a RabbitMQ connector?

Posted by vino yang <ya...@gmail.com>.
Hi Christofer Dutz,

That's all right. I think the RabbitMQ's licenses would not be a problem.
There are many open source systems and libraries which have integrated with
it.

RabbitMQ can support the MQTT with adapter (plugin), it would be good for
the IoT devices. More detail : http://www.rabbitmq.com/mqtt.html

I hope the connector would be added to edgent to enhance it's connectivity.

vinoyang
Thanks.

2018-03-04 20:35 GMT+08:00 Christofer Dutz <ch...@c-ware.de>:

> Hi Vinoyang,
>
> I had a look at your pull-requests (well the gitignore one is quite
> trivial and hence very easy to review ;))
>
> There was one thing that I wanted to double-check, but the used RabitMQ
> client library is triple licensed, one of them being Apache 2.0, so that's
> perfect.
>
> Unfortunately I'm not yet that deep into the details of Edgent, so I would
> like to ask Dale or someone who knows the inner workings a little more than
> me to re-check and do the merge.
>
> Chris
>
>
>
> Am 26.02.18, 07:22 schrieb "vino yang" <ya...@gmail.com>:
>
>     Hi christofer.dutz:
>
>     Thanks for your reply! I will do this task.
>
>     vinoyang
>
>     2018-02-26 14:16 GMT+08:00 Christofer Dutz <christofer.dutz@c-ware.de
> >:
>
>     > Sorry,
>     >
>     > I was traveling yesterday and sick the days before.
>     > Well I did have a look and I do agree that a rabbitmq connector
> could be a
>     > valuable addition. As long as the needed libraries have Apache
> compatible
>     > licensees.
>     >
>     > Chris
>     >
>     > Outlook for Android<https://aka.ms/ghei36> herunterladen
>     >
>     > ________________________________
>     > From: vino yang <ya...@gmail.com>
>     > Sent: Monday, February 26, 2018 4:36:23 AM
>     > To: dev@edgent.apache.org
>     > Subject: Re: Can I Contribute a RabbitMQ connector?
>     >
>     > No one can give some comment?
>     >
>     > 2018-02-25 15:39 GMT+08:00 vino yang <ya...@gmail.com>:
>     >
>     > > Hi :
>     > > I find there is no one RabbitMQ connector for edgent. I want to
>     > contribute
>     > > a RabbitMQ connector. How about this idea? Is there someone
> working for
>     > > this?
>     > >
>     > > Thanks!
>     > > vinoyang
>     > >
>     >
>
>
>