Re: Review Request: CLOUDSTACK-1429: single account is unable to use same vnet across multiple physical networks

[Marcus Sorensen <sh...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9651/#review17251
-----------------------------------------------------------


this looks sensible to me, but I'd want Kishan Kavala to look it over as well since he made the schema constraint change to allow same vlan on different physical networks.


- Marcus Sorensen


On Feb. 27, 2013, 1:53 p.m., venkata swamy babu  budumuru wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9651/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2013, 1:53 p.m.)
> 
> 
> Review request for cloudstack and Marcus Sorensen.
> 
> 
> Description
> -------
> 
> to repro 
> 
> (1) Have an advanced zone with physical networks say Phynet1: 900-905 Phynet2: 905-909
> (2) create a Network in physical network1 (id : 200) and deploy a vm (for ex:- network created is using vlan 905 )
> (3) create another network in physical network2 (id : 201) and deploy a vm 
> 
> Observations :
> 
> (i) It tried to pick up vlan 905 from physical network 2 (id : 201) and it failed with the following error.
> 
> Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Duplicate entry '905-1-3' for key 'i_op_dc_vnet_alloc__vnet__data_center_id__account_id'
> 
> Attached patch fixes the issue.
> 
> 
> This addresses bug CLOUDSTACK-1429.
> 
> 
> Diffs
> -----
> 
>   setup/db/db/schema-40to410.sql 59b2a7d 
> 
> Diff: https://reviews.apache.org/r/9651/diff/
> 
> 
> Testing
> -------
> 
> Retried the scenario with the dropped index and it works successfully.
> 
> 
> Thanks,
> 
> venkata swamy babu  budumuru
> 
>