[GitHub] [incubator-uniffle] leixm commented on a diff in pull request #742: [#133] feat(netty): Add Encoder and Decoder.

["leixm (via GitHub)" <gi...@apache.org>]

leixm commented on code in PR #742:
URL: https://github.com/apache/incubator-uniffle/pull/742#discussion_r1141930285


##########
internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcClient.java:
##########
@@ -319,7 +319,7 @@ public RssSendShuffleDataResponse sendShuffleData(RssSendShuffleDataRequest requ
               .setLength(sbi.getLength())
               .setTaskAttemptId(sbi.getTaskAttemptId())
               .setUncompressLength(sbi.getUncompressLength())
-              .setData(ByteString.copyFrom(sbi.getData()))
+              .setData(ByteString.copyFrom(sbi.getData().nioBuffer()))

Review Comment:
   ByteBuf.nioBuffer() will not cause a copy of the byte array, So there is no difference from before the modification.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org