You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by borisroman <gi...@git.apache.org> on 2015/11/05 16:32:33 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1039
CLOUDSTACK-9039: Fix paths for logging Ubuntu Management
Fix paths for logging Ubuntu Management.
How to test:
Install via DEB packages...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9039
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1039.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1039
----
commit 7ae487f9c6f88f2bc55e375edba3e3d9359cc10d
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-11-05T15:30:14Z
CLOUDSTACK-9039: Fix paths for logging Ubuntu Management
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1039#issuecomment-154411673
@wido @ustcweizhou Could you review again please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44210798
--- Diff: python/lib/cloudutils/serviceConfig.py ---
@@ -54,7 +54,7 @@ def configration(self):
except:
logging.debug(formatExceptionInfo())
if self.syscfg.env.mode == "Server":
- raise CloudRuntimeException("Configure %s failed, Please check the /var/log/cloudstack/setupManagement.log for detail"%self.serviceName)
+ raise CloudRuntimeException("Configure %s failed, Please check the /var/log/cloudstack/management/setupManagement.log for detail"%self.serviceName)
--- End diff --
Does this need to be hard-coded? I had a quick look into the python logging and am hoping we can retrieve the path from there. just a thought
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44132316
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,8 @@ def checkHostName():
bash("chown cloud.cloud /var/run/cloudstack-management.pid")
#distro like sl 6.1 needs this folder, or tomcat6 failed to start
checkHostName()
- bash("mkdir /var/log/cloudstack-management/")
+ bash("mkdir -p /var/log/cloudstack/")
+ bash("mkdir -p /var/log/cloudstack/management/")
--- End diff --
Both lines can be removed. The packaging already creates them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1039#issuecomment-154350435
@borisroman LGTM if remove line 110.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44116130
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,8 @@ def checkHostName():
bash("chown cloud.cloud /var/run/cloudstack-management.pid")
#distro like sl 6.1 needs this folder, or tomcat6 failed to start
checkHostName()
- bash("mkdir /var/log/cloudstack-management/")
+ bash("mkdir -p /var/log/cloudstack/")
+ bash("mkdir -p /var/log/cloudstack/management/")
--- End diff --
you could remove line 110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1039#issuecomment-154405523
FYI: Started tests on this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1039#issuecomment-155053983
@wido @ustcweizhou Can you look again here please, see @borisroman's comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44271484
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,7 @@ def checkHostName():
bash("chown cloud.cloud /var/run/cloudstack-management.pid")
#distro like sl 6.1 needs this folder, or tomcat6 failed to start
--- End diff --
It looks like a xen release!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44112143
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,8 @@ def checkHostName():
bash("chown cloud.cloud /var/run/cloudstack-management.pid")
#distro like sl 6.1 needs this folder, or tomcat6 failed to start
checkHostName()
- bash("mkdir /var/log/cloudstack-management/")
+ bash("mkdir /var/log/cloudstack/")
+ bash("mkdir /var/log/cloudstack/management/")
--- End diff --
Perhaps use
mkdir -p /var/log/cloudstack/management/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1039#issuecomment-154343137
@ustcweizhou This is only for the management server! The usage server will create it's own paths when installed. @milamberspace I'll push that change, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44112930
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,8 @@ def checkHostName():
bash("chown cloud.cloud /var/run/cloudstack-management.pid")
#distro like sl 6.1 needs this folder, or tomcat6 failed to start
checkHostName()
- bash("mkdir /var/log/cloudstack-management/")
+ bash("mkdir /var/log/cloudstack/")
+ bash("mkdir /var/log/cloudstack/management/")
--- End diff --
I agree with @milamberspace .
btw, what about the /var/log/cloudstack/usage for usage server?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44280237
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,7 @@ def checkHostName():
bash("chown cloud.cloud /var/run/cloudstack-management.pid")
#distro like sl 6.1 needs this folder, or tomcat6 failed to start
--- End diff --
ok, @remibergsma either slackware or suse linux then
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44274922
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,7 @@ def checkHostName():
bash("chown cloud.cloud /var/run/cloudstack-management.pid")
#distro like sl 6.1 needs this folder, or tomcat6 failed to start
--- End diff --
@DaanHoogland No, this should be an OS capable of running the management server.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44271177
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,7 @@ def checkHostName():
bash("chown cloud.cloud /var/run/cloudstack-management.pid")
#distro like sl 6.1 needs this folder, or tomcat6 failed to start
--- End diff --
@borisroman Did you see this remark in the code? Is that about the line you remove here? I have no clue what `sl 6.1` is.. Seems like a RHEL like release? Scientific Linux? I dunno! Does it hurt to have the dir? We better remove it later when master is unfrozen IMHO as we do not have a change to test this properly otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44275343
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,7 @@ def checkHostName():
bash("chown cloud.cloud /var/run/cloudstack-management.pid")
#distro like sl 6.1 needs this folder, or tomcat6 failed to start
--- End diff --
@remibergsma Grepping yields:
```
grep "/var/log/cloudstack-management/" . -r
./python/lib/cloudutils/serviceConfigServer.py: bash("mkdir /var/log/cloudstack-management/")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44275233
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,7 @@ def checkHostName():
bash("chown cloud.cloud /var/run/cloudstack-management.pid")
#distro like sl 6.1 needs this folder, or tomcat6 failed to start
--- End diff --
@remibergsma Could you point me to a couple lines of code where /var/log/cloudstack-management/ is used in current master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44270972
--- Diff: python/lib/cloudutils/serviceConfig.py ---
@@ -54,7 +54,7 @@ def configration(self):
except:
logging.debug(formatExceptionInfo())
if self.syscfg.env.mode == "Server":
- raise CloudRuntimeException("Configure %s failed, Please check the /var/log/cloudstack/setupManagement.log for detail"%self.serviceName)
+ raise CloudRuntimeException("Configure %s failed, Please check the /var/log/cloudstack/management/setupManagement.log for detail"%self.serviceName)
--- End diff --
@DaanHoogland You have a valid point, but this is been done throughout all this Python code. Let's fix it later in one go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44271548
--- Diff: python/lib/cloudutils/serviceConfig.py ---
@@ -54,7 +54,7 @@ def configration(self):
except:
logging.debug(formatExceptionInfo())
if self.syscfg.env.mode == "Server":
- raise CloudRuntimeException("Configure %s failed, Please check the /var/log/cloudstack/setupManagement.log for detail"%self.serviceName)
+ raise CloudRuntimeException("Configure %s failed, Please check the /var/log/cloudstack/management/setupManagement.log for detail"%self.serviceName)
--- End diff --
k
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1039#issuecomment-155115419
OK, now these became a textual change in Python. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1039#issuecomment-154409103
@remibergsma @ustcweizhou As @wido pointed out, they are already created through the packager.
https://github.com/apache/cloudstack/blob/master/debian/rules#L61
https://github.com/apache/cloudstack/blob/master/debian/cloudstack-management.install#L43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9039: Fix paths for logging Ub...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1039
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---