[GitHub] [sling-org-apache-sling-xss] rombert commented on a diff in pull request #30: SLING-11592 - Fix policy adapter condition chaining and add tests

[GitBox <gi...@apache.org>]

rombert commented on code in PR #30:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/30#discussion_r1000827100


##########
src/main/java/org/apache/sling/xss/impl/xml/AntiSamyRules.java:
##########
@@ -125,3 +126,10 @@ public Map<String, Pattern> getCommonPatternByName() {
                 .collect(Collectors.toMap(Regexp::getName, Regexp::getPattern));
     }
 }
+
+/**
+ * Attribute, Property and Tag names use the English locale, which may differ from the original config
+ */
+class AntiSamyConfigLocale {

Review Comment:
   I find non-nested classes in the same file confusing, maybe make it a static inner class?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org