You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> on 2008/09/22 22:24:28 UTC
[RFC] [PATCH] Move declarations of svn_auth_get_(gnome_keyring|kwallet)_* to svn_auth.h
I would like to suggest to move declarations of svn_auth_get_(gnome_keyring|kwallet)_*
from svn_auth_dso.h to svn_auth.h.
[[[
Move declarations of svn_auth_get_(gnome_keyring|kwallet)_* to svn_auth.h.
* subversion/include/svn_auth.h
(svn_auth_get_gnome_keyring_simple_provider,
svn_auth_get_gnome_keyring_ssl_client_cert_pw_provider,
svn_auth_get_kwallet_simple_provider,
svn_auth_get_kwallet_ssl_client_cert_pw_provider): Move to here from
svn_auth_dso.h.
* subversion/include/svn_auth_dso.h: Delete.
* subversion/libsvn_auth_gnome_keyring/gnome_keyring.c:
* subversion/libsvn_auth_kwallet/kwallet.cpp: Don't include "svn_auth_dso.h".
* build/generator/extractor.py
(_filter_names): Append svn_auth_get_*_provider.
]]]
--
Arfrever Frehtes Taifersar Arahesis
Re: [RFC] [PATCH] Move declarations of svn_auth_get_(gnome_keyring|kwallet)_* to svn_auth.h
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-09-23 00:24:28 Arfrever Frehtes Taifersar Arahesis napisał(a):
> I would like to suggest to move declarations of svn_auth_get_(gnome_keyring|kwallet)_*
> from svn_auth_dso.h to svn_auth.h.
>
> [[[
> Move declarations of svn_auth_get_(gnome_keyring|kwallet)_* to svn_auth.h.
>
> * subversion/include/svn_auth.h
> (svn_auth_get_gnome_keyring_simple_provider,
> svn_auth_get_gnome_keyring_ssl_client_cert_pw_provider,
> svn_auth_get_kwallet_simple_provider,
> svn_auth_get_kwallet_ssl_client_cert_pw_provider): Move to here from
> svn_auth_dso.h.
>
> * subversion/include/svn_auth_dso.h: Delete.
>
> * subversion/libsvn_auth_gnome_keyring/gnome_keyring.c:
> * subversion/libsvn_auth_kwallet/kwallet.cpp: Don't include "svn_auth_dso.h".
>
> * build/generator/extractor.py
> (_filter_names): Append svn_auth_get_*_provider.
> ]]]
>
Committed in r33269.
--
Arfrever Frehtes Taifersar Arahesis
Re: [RFC] [PATCH] Move declarations of svn_auth_get_(gnome_keyring|kwallet)_* to svn_auth.h
Posted by Jeremy Whitlock <jc...@gmail.com>.
> I would like to suggest to move declarations of svn_auth_get_(gnome_keyring|kwallet)_*
> from svn_auth_dso.h to svn_auth.h.
>
> [[[
> Move declarations of svn_auth_get_(gnome_keyring|kwallet)_* to svn_auth.h.
>
> * subversion/include/svn_auth.h
> (svn_auth_get_gnome_keyring_simple_provider,
> svn_auth_get_gnome_keyring_ssl_client_cert_pw_provider,
> svn_auth_get_kwallet_simple_provider,
> svn_auth_get_kwallet_ssl_client_cert_pw_provider): Move to here from
> svn_auth_dso.h.
>
> * subversion/include/svn_auth_dso.h: Delete.
>
> * subversion/libsvn_auth_gnome_keyring/gnome_keyring.c:
> * subversion/libsvn_auth_kwallet/kwallet.cpp: Don't include "svn_auth_dso.h".
>
> * build/generator/extractor.py
> (_filter_names): Append svn_auth_get_*_provider.
> ]]]
>
> --
> Arfrever Frehtes Taifersar Arahesis
>
I like this idea since it would be more inline with what was
previously in svn_auth.h for Mac OSX's Keychain support. I also like
the fact that this would mean no auth-specific shared library when
building in support for kwallet or gnome-keyring. +1
--
Take care,
Jeremy Whitlock
http://www.thoughtspark.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [RFC] [PATCH] Move declarations of svn_auth_get_(gnome_keyring|kwallet)_* to svn_auth.h
Posted by Greg Stein <gs...@gmail.com>.
Totally +1
I see no reason that other header was created in the first place, and
we should be keeping a tight, narrow scope on our API and count of
headers. Too many, and it grows in needless complexity.
Thx,
-g
On Sep 22, 2008, at 17:24, Arfrever Frehtes Taifersar Arahesis <arfrever.fta@gmail.com
> wrote:
> I would like to suggest to move declarations of
> svn_auth_get_(gnome_keyring|kwallet)_*
> from svn_auth_dso.h to svn_auth.h.
>
> [[[
> Move declarations of svn_auth_get_(gnome_keyring|kwallet)_* to
> svn_auth.h.
>
> * subversion/include/svn_auth.h
> (svn_auth_get_gnome_keyring_simple_provider,
> svn_auth_get_gnome_keyring_ssl_client_cert_pw_provider,
> svn_auth_get_kwallet_simple_provider,
> svn_auth_get_kwallet_ssl_client_cert_pw_provider): Move to here from
> svn_auth_dso.h.
>
> * subversion/include/svn_auth_dso.h: Delete.
>
> * subversion/libsvn_auth_gnome_keyring/gnome_keyring.c:
> * subversion/libsvn_auth_kwallet/kwallet.cpp: Don't include
> "svn_auth_dso.h".
>
> * build/generator/extractor.py
> (_filter_names): Append svn_auth_get_*_provider.
> ]]]
>
> --
> Arfrever Frehtes Taifersar Arahesis
> <subversion-move_declarations.patch>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org