You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/03 15:03:52 UTC

[GitHub] [tvm] sergey-grovety opened a new pull request, #13281: [microNPU] Fixed MergeConstants pass on striped networks

sergey-grovety opened a new pull request, #13281:
URL: https://github.com/apache/tvm/pull/13281

   This PR fixes the bug in MergeConstants pass on striped networks on Ethos-U NPU.
   
   The issue was caused by _DivideConstants_ pass which is introducing new mod parameters and changing their order. So ethosu_write parameter in some cases is moved from the end of the list to the middle.
   E.g. from:
   `[ethos-u_0_i0, p1, p2, p3, p4, p5, p6, ethosu_write]`
   To:
   `[ethos-u_0_i0, p1, p2, ethosu_write, placeholder, placeholder, placeholder, placeholder, placeholder, placeholder, placeholder, placeholder]`
   
   Updated version of the  _GetArgsToMergeWithoutArgsNotInConstDict_ and _MakeNewConstDict_ methods in passes.cc can now correctly modify const_dict according to the new parameter list.
   
   cc @leandron 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] lhutton1 commented on pull request #13281: [microNPU] Fixed MergeConstants pass on striped networks

Posted by GitBox <gi...@apache.org>.

lhutton1 commented on PR #13281:
URL: https://github.com/apache/tvm/pull/13281#issuecomment-1309970532

   Thanks @sergey-grovety @NicolaLancellotti!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] lhutton1 merged pull request #13281: [microNPU] Fixed MergeConstants pass on striped networks

Posted by GitBox <gi...@apache.org>.

lhutton1 merged PR #13281:
URL: https://github.com/apache/tvm/pull/13281


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #13281: [microNPU] Fixed MergeConstants pass on striped networks

Posted by GitBox <gi...@apache.org>.

tvm-bot commented on PR #13281:
URL: https://github.com/apache/tvm/pull/13281#issuecomment-1302248885

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Mousius, @lhutton1 <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org