[cordova-windows] 01/26: comments in MSBuildTools.js

[ja...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-msbuild_cleanup
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git

commit ddcd3c0dad4392d8d5c8856f5b20ffcf5af92d9b
Author: Jan Piotrowski <pi...@gmail.com>
AuthorDate: Wed Feb 14 18:49:43 2018 +0100

    comments in MSBuildTools.js
---
 template/cordova/lib/MSBuildTools.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/template/cordova/lib/MSBuildTools.js b/template/cordova/lib/MSBuildTools.js
index eb9d7f0..cfbf4e0 100644
--- a/template/cordova/lib/MSBuildTools.js
+++ b/template/cordova/lib/MSBuildTools.js
@@ -37,18 +37,20 @@ MSBuildTools.prototype.buildProject = function (projFile, buildType, buildarch,
     events.emit('log', '\tBuildflags    : ' + buildFlags);
     events.emit('log', '\tMSBuildTools  : ' + this.path);
 
+    // Additional requirement checks
     var checkWinSDK = function (target_platform) {
         return require('./check_reqs').isWinSDKPresent(target_platform);
     };
-
     var checkPhoneSDK = function () {
         return require('./check_reqs').isPhoneSDKPresent();
     };
 
+    // default build args
     var args = ['/clp:NoSummary;NoItemAndPropertyList;Verbosity=minimal', '/nologo',
         '/p:Configuration=' + buildType,
         '/p:Platform=' + buildarch];
 
+    // add buildFlags if present
     if (buildFlags) {
         args = args.concat(buildFlags);
     }
@@ -140,6 +142,8 @@ function checkMSBuildVersion (version) {
             return module.exports.getMSBuildToolsAt(toolsPath);
         }
     }
+
+    // older vs versions that were registered in registry
     return spawn('reg', ['query', 'HKLM\\SOFTWARE\\Microsoft\\MSBuild\\ToolsVersions\\' + version, '/v', 'MSBuildToolsPath'])
         .then(function (output) {
             // fetch msbuild path from 'reg' output

-- 
To stop receiving notification emails like this one, please contact
janpio@apache.org.

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org