You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mahesh Bandal <ma...@gmail.com> on 2020/06/05 14:01:36 UTC

Review Request 72571: RANGER-2849: Allow Ranger to be configurable to not disclose server version

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72571/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2849
    https://issues.apache.org/jira/browse/RANGER-2849


Repository: ranger


Description
-------

Allow Ranger to be configurable to not disclose server version


Diffs
-----

  embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java dc931c25d 
  security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 3eb47f932 


Diff: https://reviews.apache.org/r/72571/diff/1/


Testing
-------

After getting error/exception ranger does not disclose server version if ranger.valve.errorreportvalve.showserverinfo set to false. When ranger.valve.errorreportvalve.showreport is set to false; it does not disclose exception message in response.


Thanks,

Mahesh Bandal


Re: Review Request 72571: RANGER-2849: Allow Ranger to be configurable to not disclose server version

Posted by Kishor Gollapalliwar <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72571/#review220991
-----------------------------------------------------------


Ship it!




Ship It!

- Kishor Gollapalliwar


On June 5, 2020, 2:01 p.m., Mahesh Bandal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72571/
> -----------------------------------------------------------
> 
> (Updated June 5, 2020, 2:01 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2849
>     https://issues.apache.org/jira/browse/RANGER-2849
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Allow Ranger to be configurable to not disclose server version
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java dc931c25d 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 3eb47f932 
> 
> 
> Diff: https://reviews.apache.org/r/72571/diff/1/
> 
> 
> Testing
> -------
> 
> After getting error/exception ranger does not disclose server version if ranger.valve.errorreportvalve.showserverinfo set to false. When ranger.valve.errorreportvalve.showreport is set to false; it does not disclose exception message in response.
> 
> 
> Thanks,
> 
> Mahesh Bandal
> 
>


Re: Review Request 72571: RANGER-2849: Allow Ranger to be configurable to not disclose server version

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72571/#review220987
-----------------------------------------------------------


Ship it!




Ship It!

- Pradeep Agrawal


On June 5, 2020, 2:01 p.m., Mahesh Bandal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72571/
> -----------------------------------------------------------
> 
> (Updated June 5, 2020, 2:01 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2849
>     https://issues.apache.org/jira/browse/RANGER-2849
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Allow Ranger to be configurable to not disclose server version
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java dc931c25d 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 3eb47f932 
> 
> 
> Diff: https://reviews.apache.org/r/72571/diff/1/
> 
> 
> Testing
> -------
> 
> After getting error/exception ranger does not disclose server version if ranger.valve.errorreportvalve.showserverinfo set to false. When ranger.valve.errorreportvalve.showreport is set to false; it does not disclose exception message in response.
> 
> 
> Thanks,
> 
> Mahesh Bandal
> 
>