You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2023/08/09 17:28:08 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #33231: Improve fetching logs from AWS

eladkal commented on code in PR #33231:
URL: https://github.com/apache/airflow/pull/33231#discussion_r1288944532


##########
airflow/providers/amazon/aws/hooks/logs.py:
##########
@@ -60,6 +61,7 @@ def get_log_events(
         log_group: str,
         log_stream_name: str,
         start_time: int = 0,
+        end_time: int | None = None,

Review Comment:
   should there be also an updated test case in `TestAwsLogsHook`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org