You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by "Vitalii Diravka (Jira)" <ji...@apache.org> on 2021/11/18 22:41:00 UTC

[jira] [Resolved] (DRILL-1896) Unit tests failing due to string based comparison at JsonStringHashMap & JsonStringArrayList #equals methods

     [ https://issues.apache.org/jira/browse/DRILL-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vitalii Diravka resolved DRILL-1896.
------------------------------------
    Resolution: Fixed

_jsonBaselineFile_ is doing a new Drill query. The result for this and original query is different, because of _SchemaChange_ in the original query. So need to compare the result of the query with baselineValues. Resolved in DRILL-8046

> Unit tests failing due to string based comparison at JsonStringHashMap & JsonStringArrayList #equals methods
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-1896
>                 URL: https://issues.apache.org/jira/browse/DRILL-1896
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Hanifi Gunes
>            Assignee: Vitalii Diravka
>            Priority: Major
>             Fix For: 0.8.0
>
>         Attachments: DRILL-1896-v3.patch, DRILL-1896.patch, RILL-1896-v2.patch
>
>
> Unit test framework relies on JsonString*#equals methods to compare actual and expected results. We should properly implement these to prevent unit tests from failing.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)