You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/02/27 10:23:42 UTC

[GitHub] [kylin] harveyyue opened a new pull request #1125: KYLIN-4387 Flink cubing merge step failed

harveyyue opened a new pull request #1125: KYLIN-4387 Flink cubing merge step failed
URL: https://github.com/apache/kylin/pull/1125
 
 
   Code changes:
   1. Using RichGroupReduceFunction instead of ReduceFunction to improve the performance
   2. Using ByteArray instead of Text in reduceGroup operator to fix the LinkageError
   
   JIRA ref: https://issues.apache.org/jira/browse/KYLIN-4387

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls edited a comment on issue #1125: KYLIN-4387 Flink cubing merge step failed

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1125: KYLIN-4387 Flink cubing merge step failed
URL: https://github.com/apache/kylin/pull/1125#issuecomment-591915499
 
 
   ## Pull Request Test Coverage Report for [Build 5673](https://coveralls.io/builds/29054294)
   
   * **0** of **30**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * **9** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.009%**) to **27.518%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [engine-flink/src/main/java/org/apache/kylin/engine/flink/FlinkCubingMerge.java](https://coveralls.io/builds/29054294/source?filename=engine-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fflink%2FFlinkCubingMerge.java#L153) | 0 | 30 | 0.0%
   <!-- | **Total:** | **0** | **30** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/29054294/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
   | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/29054294/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29054294/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
   <!-- | **Total:** | **9** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29054294/badge)](https://coveralls.io/builds/29054294) |
   | :-- | --: |
   | Change from base [Build 5670](https://coveralls.io/builds/29043776): |  -0.009% |
   | Covered Lines: | 24294 |
   | Relevant Lines: | 88284 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi commented on a change in pull request #1125: KYLIN-4387 Flink cubing merge step failed

Posted by GitBox <gi...@apache.org>.
shaofengshi commented on a change in pull request #1125: KYLIN-4387 Flink cubing merge step failed
URL: https://github.com/apache/kylin/pull/1125#discussion_r386427647
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -748,6 +751,24 @@
         <version>${kryo.version}</version>
         <scope>provided</scope>
       </dependency>
+      <!-- Flink dependency -->
+      <dependency>
+        <groupId>org.apache.flink</groupId>
+        <artifactId>flink-java</artifactId>
+        <version>${flink.version}</version>
+        <scope>provided</scope>
+      </dependency>
+      <dependency>
+        <groupId>org.apache.flink</groupId>
+        <artifactId>flink-scala_2.11</artifactId>
+        <version>${flink.version}</version>
+        <scope>provided</scope>
+      </dependency>
+      <dependency>
+        <groupId>org.apache.flink</groupId>
+        <artifactId>flink-hadoop-compatibility_2.11</artifactId>
+        <version>${flink.version}</version>
 
 Review comment:
   Does this also need be "provided"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi closed pull request #1125: KYLIN-4387 Flink cubing merge step failed

Posted by GitBox <gi...@apache.org>.
shaofengshi closed pull request #1125: KYLIN-4387 Flink cubing merge step failed
URL: https://github.com/apache/kylin/pull/1125
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi commented on issue #1125: KYLIN-4387 Flink cubing merge step failed

Posted by GitBox <gi...@apache.org>.
shaofengshi commented on issue #1125: KYLIN-4387 Flink cubing merge step failed
URL: https://github.com/apache/kylin/pull/1125#issuecomment-593432722
 
 
   I should close this one, and reopen the other.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #1125: KYLIN-4387 Flink cubing merge step failed

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1125: KYLIN-4387 Flink cubing merge step failed
URL: https://github.com/apache/kylin/pull/1125#issuecomment-593080402
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1125?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@7431586`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `4%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1125/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1125?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1125   +/-   ##
   =========================================
     Coverage          ?   25.05%           
     Complexity        ?     6248           
   =========================================
     Files             ?     1446           
     Lines             ?    88284           
     Branches          ?    12353           
   =========================================
     Hits              ?    22119           
     Misses            ?    63993           
     Partials          ?     2172
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1125?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...coordinator/coordinate/ReceiverClusterManager.java](https://codecov.io/gh/apache/kylin/pull/1125/diff?src=pr&el=tree#diff-c3RyZWFtLWNvb3JkaW5hdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdHJlYW0vY29vcmRpbmF0b3IvY29vcmRpbmF0ZS9SZWNlaXZlckNsdXN0ZXJNYW5hZ2VyLmphdmE=) | `0.28% <ø> (ø)` | `1 <0> (?)` | |
   | [...n/stream/core/storage/StreamingSegmentManager.java](https://codecov.io/gh/apache/kylin/pull/1125/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvU3RyZWFtaW5nU2VnbWVudE1hbmFnZXIuamF2YQ==) | `23.57% <ø> (ø)` | `17 <0> (?)` | |
   | [...rg/apache/kylin/engine/flink/FlinkCubingMerge.java](https://codecov.io/gh/apache/kylin/pull/1125/diff?src=pr&el=tree#diff-ZW5naW5lLWZsaW5rL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvZmxpbmsvRmxpbmtDdWJpbmdNZXJnZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...che/kylin/job/execution/CardinalityExecutable.java](https://codecov.io/gh/apache/kylin/pull/1125/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQ2FyZGluYWxpdHlFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...rg/apache/kylin/stream/server/StreamingServer.java](https://codecov.io/gh/apache/kylin/pull/1125/diff?src=pr&el=tree#diff-c3RyZWFtLXJlY2VpdmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdHJlYW0vc2VydmVyL1N0cmVhbWluZ1NlcnZlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [.../java/org/apache/kylin/engine/spark/SparkUtil.java](https://codecov.io/gh/apache/kylin/pull/1125/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtVdGlsLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...va/org/apache/kylin/rest/service/TableService.java](https://codecov.io/gh/apache/kylin/pull/1125/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9UYWJsZVNlcnZpY2UuamF2YQ==) | `13.79% <0%> (ø)` | `9 <0> (?)` | |
   | [.../org/apache/kylin/rest/job/MetadataCleanupJob.java](https://codecov.io/gh/apache/kylin/pull/1125/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL01ldGFkYXRhQ2xlYW51cEpvYi5qYXZh) | `64.78% <28.57%> (ø)` | `26 <0> (?)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1125?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1125?src=pr&el=footer). Last update [7431586...d965808](https://codecov.io/gh/apache/kylin/pull/1125?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls commented on issue #1125: KYLIN-4387 Flink cubing merge step failed

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1125: KYLIN-4387 Flink cubing merge step failed
URL: https://github.com/apache/kylin/pull/1125#issuecomment-591915499
 
 
   ## Pull Request Test Coverage Report for [Build 5665](https://coveralls.io/builds/28995272)
   
   * **0** of **30**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * **1** unchanged line in **1** file lost coverage.
   * Overall coverage decreased (**-0.003%**) to **27.526%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [engine-flink/src/main/java/org/apache/kylin/engine/flink/FlinkCubingMerge.java](https://coveralls.io/builds/28995272/source?filename=engine-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fflink%2FFlinkCubingMerge.java#L153) | 0 | 30 | 0.0%
   <!-- | **Total:** | **0** | **30** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28995272/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553) | 1 | 78.12% |
   <!-- | **Total:** | **1** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28995272/badge)](https://coveralls.io/builds/28995272) |
   | :-- | --: |
   | Change from base [Build 5663](https://coveralls.io/builds/28990866): |  -0.003% |
   | Covered Lines: | 24297 |
   | Relevant Lines: | 88268 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services