You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/28 03:23:45 UTC
[GitHub] [incubator-dolphinscheduler] gnuhpc opened a new pull request
#1620: Fix a out-of-date comment
gnuhpc opened a new pull request #1620: Fix a out-of-date comment
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1620
## *Tips*
- *Thanks very much for contributing to Apache DolphinScheduler.*
- *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.*
## What is the purpose of the pull request
fix a comment
## Brief change log
From the default of the parameter master.heartbeat.interval, it can be seen that the default heart beat interval is 10s.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1620:
Fix a out-of-date comment
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #1620: Fix a out-of-date comment
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1620#issuecomment-569408042
because this is a very small issue fix, I want to merge it when I reviewed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1620:
Fix a out-of-date comment
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1620: Fix a out-of-date comment
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1620#issuecomment-569380777
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1620?src=pr&el=h1) Report
> Merging [#1620](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1620?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/be5fc116effe456cb9b74b277a3fb5c3988e6870?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1620?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1620 +/- ##
=====================================
Coverage 8.11% 8.11%
=====================================
Files 282 282
Lines 13785 13785
Branches 2201 2201
=====================================
Hits 1118 1118
Misses 12583 12583
Partials 84 84
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1620?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...e/dolphinscheduler/server/master/MasterServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1620/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9NYXN0ZXJTZXJ2ZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1620?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1620?src=pr&el=footer). Last update [be5fc11...37d5657](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1620?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong closed pull request #1620:
Fix a out-of-date comment
Posted by GitBox <gi...@apache.org>.
dailidong closed pull request #1620: Fix a out-of-date comment
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1620
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services