[GitHub] [helix] qqu0127 commented on pull request #1948: Introduce VirtualTopologyGroup and its assignment logic with benchmark.

[GitBox <gi...@apache.org>]

qqu0127 commented on pull request #1948:
URL: https://github.com/apache/helix/pull/1948#issuecomment-1023611265


   > @qqu0127 I would like a clarification please: the final choice of assignment logic is one of the three choices, is that correct? If so, the benchmarking should be done in offline code and only the best one should be selected and checked in. Let me know if I have a misunderstanding.
   
   @NealSun96 
   Eventually, yes, I expect only one is used for non-test. I open this and include all choices in order to share the code and as a reference to help better understand the design. 
   We have two options here, one is to merge this PR as it is with all 3, and cleanup in a following PR. This is targeting a project branch after all. 
   Second option is to update this PR after review with a new commit. I prefer the first one though.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org