[GitHub] [incubator-superset] villebro commented on a change in pull request #9661: feat: Add geospatial post processing operations

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #9661:
URL: https://github.com/apache/incubator-superset/pull/9661#discussion_r416671611



##########
File path: superset/charts/schemas.py
##########
@@ -265,15 +265,23 @@ class ChartDataSelectOptionsSchema(ChartDataPostProcessingOperationOptionsSchema
     columns = fields.List(
         fields.String(),
         description="Columns which to select from the input data, in the desired "
-        "order. If columns are renamed, the old column name should be "
+        "order. If columns are renamed, the original column name should be "
         "referenced here.",
         example=["country", "gender", "age"],
+        required=False,
+    )
+    drop = fields.List(

Review comment:
       Done. I was originally going to use `exclude`, but seems I forgot and ended up using `drop` as pandas uses that name.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org