You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "jdaugherty (via GitHub)" <gi...@apache.org> on 2025/09/02 17:08:54 UTC

[PR] Update to Asset Pipeline 5.0.16 [grails-core]

jdaugherty opened a new pull request, #15040:
URL: https://github.com/apache/grails-core/pull/15040

   As a follow-up to https://github.com/apache/grails-core/pull/14953, since we depend on the asset pipeline, the coordinate change for grails-i18n broke forge.  This should resolve it once 5.0.16 is findable on maven central.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update to Asset Pipeline 5.0.16 [grails-core]

Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on code in PR #15040:
URL: https://github.com/apache/grails-core/pull/15040#discussion_r2317874839


##########
grails-forge/grails-forge-cli/src/test/groovy/org/grails/forge/cli/CommandSpec.groovy:
##########
@@ -70,6 +70,7 @@ class CommandSpec extends Specification {
         String[] args = builder.toString().split(' ')
         ProcessBuilder pb = new ProcessBuilder(args)
         pb.environment().put('JAVA_HOME', System.getenv('JAVA_HOME') ?: System.getProperty('java.home'))
+        pb.environment().put('GRAILS_REPO_URL', System.getenv('GRAILS_REPO_URL') ?: null)

Review Comment:
   From https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/ProcessBuilder.html#environment():
   The returned map does not permit null keys or values. Attempting to insert or query the presence of a null key or value will throw a NullPointerException.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update to Asset Pipeline 5.0.16 [grails-core]

Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty merged PR #15040:
URL: https://github.com/apache/grails-core/pull/15040


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org