You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Sriharsha Chintalapani <ha...@hortonworks.com> on 2015/01/18 00:46:13 UTC

Review Request 30007: Patch for KAFKA-1867

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30007/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1867
    https://issues.apache.org/jira/browse/KAFKA-1867


Repository: kafka


Description
-------

KAFKA-1867. liveBroker list is not updated on a cluster with no topics.


Diffs
-----

  core/src/main/scala/kafka/controller/ControllerChannelManager.scala eb492f00449744bc8d63f55b393e2a1659d38454 
  core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala 420a1dd30264c72704cc383a4161034c7922177d 
  core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 5b93239cdc26b5be7696f4e7863adb9fbe5f0ed5 

Diff: https://reviews.apache.org/r/30007/diff/


Testing
-------


Thanks,

Sriharsha Chintalapani


Re: Review Request 30007: Patch for KAFKA-1867

Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30007/#review73349
-----------------------------------------------------------

Ship it!


Ship It!

- Neha Narkhede


On Jan. 26, 2015, 5:07 a.m., Sriharsha Chintalapani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30007/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2015, 5:07 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1867
>     https://issues.apache.org/jira/browse/KAFKA-1867
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1867. liveBroker list not updated on a cluster with no topics.
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala fbef34cad16afd0f77ba5e8d0bc63ea2b8e860b6 
>   core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala 90c0b7a19c7af8e5416e4bdba62b9824f1abd5ab 
>   core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 5b93239cdc26b5be7696f4e7863adb9fbe5f0ed5 
> 
> Diff: https://reviews.apache.org/r/30007/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sriharsha Chintalapani
> 
>


Re: Review Request 30007: Patch for KAFKA-1867

Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30007/
-----------------------------------------------------------

(Updated Jan. 26, 2015, 5:07 a.m.)


Review request for kafka.


Bugs: KAFKA-1867
    https://issues.apache.org/jira/browse/KAFKA-1867


Repository: kafka


Description (updated)
-------

KAFKA-1867. liveBroker list not updated on a cluster with no topics.


Diffs (updated)
-----

  core/src/main/scala/kafka/controller/ControllerChannelManager.scala fbef34cad16afd0f77ba5e8d0bc63ea2b8e860b6 
  core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala 90c0b7a19c7af8e5416e4bdba62b9824f1abd5ab 
  core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 5b93239cdc26b5be7696f4e7863adb9fbe5f0ed5 

Diff: https://reviews.apache.org/r/30007/diff/


Testing
-------


Thanks,

Sriharsha Chintalapani