You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/09/23 10:26:07 UTC
[GitHub] [hadoop] mehakmeet opened a new pull request, #4931: HADOOP-18416. fix ITestS3AIOStatisticsContext test failure
mehakmeet opened a new pull request, #4931:
URL: https://github.com/apache/hadoop/pull/4931
Follow on to HADOOP-17461.
### Description of PR
backport from trunk for test fix, also contains a commented out portion **(to be added once prefetch jira is in branch-3.3)**
### How was this patch tested?
`mvn clean verify -Dparallel-tests -DtestsThreadCount=4 -Dscale`
`[WARNING] Tests run: 417, Failures: 0, Errors: 0, Skipped: 4`
`[WARNING] Tests run: 1147, Failures: 0, Errors: 0, Skipped: 146`
`[ERROR] Tests run: 124, Failures: 0, Errors: 1, Skipped: 10` (timeout error, unrelated)
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #4931: HADOOP-18416. fix ITestS3AIOStatisticsContext test failure
Posted by GitBox <gi...@apache.org>.
steveloughran commented on PR #4931:
URL: https://github.com/apache/hadoop/pull/4931#issuecomment-1260819248
you need to cherrypick to the branch-3.3.5 branch too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] mukund-thakur commented on pull request #4931: HADOOP-18416. fix ITestS3AIOStatisticsContext test failure
Posted by GitBox <gi...@apache.org>.
mukund-thakur commented on PR #4931:
URL: https://github.com/apache/hadoop/pull/4931#issuecomment-1261470847
Cherrypicked this one in branch-3.3.5 @mehakmeet thank me later :P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #4931: HADOOP-18416. fix ITestS3AIOStatisticsContext test failure
Posted by GitBox <gi...@apache.org>.
steveloughran commented on PR #4931:
URL: https://github.com/apache/hadoop/pull/4931#issuecomment-1259321944
LGTM.
Mehakmeet, you don't need to get a +1 on a simple backport, seeing that yetus is happy is enough. if it's complicate it is still good to get some review, but only looking for risk of regressions, rather than any major change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] mehakmeet commented on pull request #4931: HADOOP-18416. fix ITestS3AIOStatisticsContext test failure
Posted by GitBox <gi...@apache.org>.
mehakmeet commented on PR #4931:
URL: https://github.com/apache/hadoop/pull/4931#issuecomment-1259483553
@steveloughran Noted. Wanted to double-check since this has a commented-out bit from the trunk changes. Wanted to see if this was within the coding standard(having a TODO comment in production code). Thanks for letting me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] mehakmeet merged pull request #4931: HADOOP-18416. fix ITestS3AIOStatisticsContext test failure
Posted by GitBox <gi...@apache.org>.
mehakmeet merged PR #4931:
URL: https://github.com/apache/hadoop/pull/4931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] mehakmeet commented on pull request #4931: HADOOP-18416. fix ITestS3AIOStatisticsContext test failure
Posted by GitBox <gi...@apache.org>.
mehakmeet commented on PR #4931:
URL: https://github.com/apache/hadoop/pull/4931#issuecomment-1256042568
CC: @steveloughran @mukund-thakur. Backport to the trunk test fix, but also contains a commented-out portion as discussed (to be added once prefetch jira is in branch-3.3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] mehakmeet commented on pull request #4931: HADOOP-18416. fix ITestS3AIOStatisticsContext test failure
Posted by GitBox <gi...@apache.org>.
mehakmeet commented on PR #4931:
URL: https://github.com/apache/hadoop/pull/4931#issuecomment-1261612986
@mukund-thakur Thanks! 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4931: HADOOP-18416. fix ITestS3AIOStatisticsContext test failure
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on PR #4931:
URL: https://github.com/apache/hadoop/pull/4931#issuecomment-1256132862
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 1m 0s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 2 new or modified test files. |
|||| _ branch-3.3 Compile Tests _ |
| +1 :green_heart: | mvninstall | 39m 8s | | branch-3.3 passed |
| +1 :green_heart: | compile | 0m 44s | | branch-3.3 passed |
| +1 :green_heart: | checkstyle | 0m 41s | | branch-3.3 passed |
| +1 :green_heart: | mvnsite | 0m 51s | | branch-3.3 passed |
| +1 :green_heart: | javadoc | 0m 46s | | branch-3.3 passed |
| +1 :green_heart: | spotbugs | 1m 27s | | branch-3.3 passed |
| +1 :green_heart: | shadedclient | 26m 45s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 42s | | the patch passed |
| +1 :green_heart: | compile | 0m 32s | | the patch passed |
| +1 :green_heart: | javac | 0m 32s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 23s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 38s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 26s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 11s | | the patch passed |
| +1 :green_heart: | shadedclient | 25m 41s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 17s | | hadoop-aws in the patch passed. |
| +1 :green_heart: | asflicense | 0m 41s | | The patch does not generate ASF License warnings. |
| | | 104m 38s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4931/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4931 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux cedd50bbc5a4 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-3.3 / efd684bcd03f16b4e2c0e3874a6a0bacd9b550a2 |
| Default Java | Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4931/1/testReport/ |
| Max. process+thread count | 526 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4931/1/console |
| versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org