[GitHub] [airflow] uranusjr commented on a change in pull request #18718: Add hook_params in BaseSqlOperator

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #18718:
URL: https://github.com/apache/airflow/pull/18718#discussion_r723745553



##########
File path: airflow/models/connection.py
##########
@@ -289,8 +289,11 @@ def rotate_fernet_key(self):
         if self._extra and self.is_extra_encrypted:
             self._extra = fernet.rotate(self._extra.encode('utf-8')).decode()
 
-    def get_hook(self):
-        """Return hook based on conn_type."""
+    def get_hook(self, **kwargs):
+        """
+        Return hook based on conn_type
+        :param hook_params: dictionary of keyword arguments to be passed to the hook constructor
+        """

Review comment:
       This docstring does not seem to match the actual argument?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org