You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "clintropolis (via GitHub)" <gi...@apache.org> on 2026/01/30 23:53:00 UTC
[PR] add vsf AcquireSegmentResult metrics to ChannelCounters (druid)
clintropolis opened a new pull request, #18971:
URL: https://github.com/apache/druid/pull/18971
This PR adds VSF metrics from `AcquireSegmentResult` (`loadBytes`, `loadTime`, `loadWait`) as well as loaded file count (`loadFiles`) to msq `ChannelCounters`.
It also updates the web-console type definitions to be aware of these values, but does not display them yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] add vsf AcquireSegmentResult metrics to ChannelCounters (druid)
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis merged PR #18971:
URL: https://github.com/apache/druid/pull/18971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] add vsf AcquireSegmentResult metrics to ChannelCounters (druid)
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #18971:
URL: https://github.com/apache/druid/pull/18971#discussion_r2748546425
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/query/QueryVirtualStorageTest.java:
##########
@@ -219,6 +232,58 @@
Assertions.assertTrue(emitter.getLatestMetricEventValue(StorageMonitor.VSF_USED_BYTES, 0).longValue() > 0);
}
+ @Test
+ void testQueryTooMuchDataButWithDart()
+ {
+ // dart uses vsf in a totally rad way so it can query all of the segments at once due to how it chunks up and
+ // fetches segments to do the work
+ final String sqlQueryId = UUID.randomUUID().toString();
+ final String resultString = cluster.callApi().onAnyBroker(
+ b -> b.submitSqlQuery(
+ new ClientSqlQuery(
+ StringUtils.format("select count(*) from \"%s\"", dataSource),
+ "CSV",
+ false,
+ false,
+ false,
+ Map.of(
+ QueryContexts.CTX_SQL_QUERY_ID, sqlQueryId,
+ QueryContexts.ENGINE, "msq-dart"
+ ),
+ null
+ )
+ )
+ ).trim();
+
+ final Long result = Long.parseLong(resultString);
Review Comment:
## Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more details](https://github.com/apache/druid/security/code-scanning/10796)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org