You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ambari.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2018/02/16 13:15:06 UTC

[jira] [Commented] (AMBARI-20736) Allow Potentially Long Running Restart Commands To Have Their Own Timeout

    [ https://issues.apache.org/jira/browse/AMBARI-20736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16367120#comment-16367120 ] 

Hudson commented on AMBARI-20736:
---------------------------------

FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #8744 (See [https://builds.apache.org/job/Ambari-trunk-Commit/8744/])
AMBARI-20736. Allow Potentially Long Running Restart Commands To Have (aonishuk: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=6407ddd256fc98e5e97b68806fd9a8c823eff805])
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapper.java
* (edit) ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml
* (edit) ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml
* (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
* (edit) ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml
* (edit) ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml
* (edit) ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
* (edit) ambari-server/src/main/resources/upgrade-pack.xsd
* (edit) ambari-common/src/main/python/resource_management/libraries/functions/decorator.py
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
* (edit) ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapperBuilder.java
* (edit) ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml
* (edit) ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java
* (edit) ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml
* (edit) ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml
* (edit) ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
* (edit) ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml
* (edit) ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py


> Allow Potentially Long Running Restart Commands To Have Their Own Timeout
> -------------------------------------------------------------------------
>
>                 Key: AMBARI-20736
>                 URL: https://issues.apache.org/jira/browse/AMBARI-20736
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>            Reporter: Nate Cole
>            Assignee: Nate Cole
>            Priority: Critical
>             Fix For: 2.5.1
>
>         Attachments: AMBARI-20736.patch
>
>
> During an upgrade of a cluster, some commands are expected to take a very long time depending on what the size of the cluster is and how much data is stored. For example, a NameNode restart with SafeMode exit may take in excess of 30 minutes. On some clusters, this could take less than 1 minute.
> Currently today, the only way to adjust these properties is to do so across the board for all commands by editing {{ambari.properties}} and setting {{agent.task.timeout}}. This solution doesn't work very well since the majority of restarts during an upgrade are not on a master component.
> There needs to be a way to instruct Ambari that a restart should be allowed to run for a relatively long period of time. 
> - Both Java and Python need to be considered here. We don't want Python to give up and return a {{FAILED}} state and we don't want Ambari server to set the task to {{TIMEDOUT}}.
> - This can be useful in both normal restarts and upgrade scenarios. 
> h3. Upgrade Only
> If considering this functionality in the context of an upgrade only, then it is conceivable that this logic can be placed inside of the upgrade XML packs:
> {code}
>     <service name="HDFS">
>       <component name="NAMENODE">
>         <upgrade>
>           <task xsi:type="restart-task"  timeout="1800"/>
>         </upgrade>
> {code}
> - This would allow future mpacks to be able to control the restart of components. Perhaps this can even be slightly abstracted out:
> {code}
>     <service name="HDFS">
>       <component name="NAMENODE">
>         <upgrade>
>           <task xsi:type="restart-task"  timeout="upgrade.parameter.master.restart.long"/>
>         </upgrade>
> upgrade.parameter.slave.restart.short = 300
> upgrade.parameter.slave.restart.long = 900
> upgrade.parameter.master.restart.short = 1500
> upgrade.parameter.master.restart.long = 1800
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)