You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@griffin.apache.org by toyboxman <gi...@git.apache.org> on 2018/07/03 13:17:56 UTC

[GitHub] incubator-griffin pull request #334: fix a bad practice, Empty interpolated ...

GitHub user toyboxman opened a pull request:

    https://github.com/apache/incubator-griffin/pull/334

    fix a bad practice, Empty interpolated string

    String declared as interpolated but has no parameters: scala.StringContext.apply("cache after replace old df").s()

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/toyboxman/incubator-griffin bug1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-griffin/pull/334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #334
    
----
commit 7b0d39fabf5e6f45c33b572a294acf3e125d95c4
Author: Eugene <to...@...>
Date:   2018-07-03T13:12:18Z

    fix a bad practice, Empty interpolated string
    
    String declared as interpolated but has no parameters: scala.StringContext.apply("cache after replace old df").s()

----


---

[GitHub] incubator-griffin issue #334: fix a bad practice, Empty interpolated string

Posted by guoyuepeng <gi...@git.apache.org>.

Github user guoyuepeng commented on the issue:

    https://github.com/apache/incubator-griffin/pull/334
  
    I agree 's' Interpolator is unnecessary for these two cases.


---

[GitHub] incubator-griffin pull request #334: fix a bad practice, Empty interpolated ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-griffin/pull/334


---