You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/01/17 18:07:17 UTC
[Impala-ASF-CR] IMPALA-9302: disable ineffective filters for mt dop > 0
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15065
Change subject: IMPALA-9302: disable ineffective filters for mt_dop > 0
......................................................................
IMPALA-9302: disable ineffective filters for mt_dop > 0
The optimisation of disabling ineffective row-level
runtime filters was not implemented in the MT scan
code paths, because the ProcessSplit() functions,
where it was implemented, are not used for mt_dop > 0.
This change adds it to HdfsScanner::GetNext(), which
is used for mt_dop > 0 but not mt_dop = 0.
Testing:
Run existing runtime row filters test with mt_dop.
This reproduced the issue before I fixed it.
Change-Id: I8a55a9d4ac9e0d93cb3675dd2d5da086cb7d941d
---
M be/src/exec/hdfs-scanner.h
M tests/custom_cluster/test_mt_dop.py
2 files changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/15065/1
--
To view, visit http://gerrit.cloudera.org:8080/15065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a55a9d4ac9e0d93cb3675dd2d5da086cb7d941d
Gerrit-Change-Number: 15065
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9302: disable ineffective filters for mt dop > 0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15065 )
Change subject: IMPALA-9302: disable ineffective filters for mt_dop > 0
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a55a9d4ac9e0d93cb3675dd2d5da086cb7d941d
Gerrit-Change-Number: 15065
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Sat, 18 Jan 2020 02:05:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9302: disable ineffective filters for mt dop > 0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15065 )
Change subject: IMPALA-9302: disable ineffective filters for mt_dop > 0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15065/1/tests/custom_cluster/test_mt_dop.py
File tests/custom_cluster/test_mt_dop.py:
http://gerrit.cloudera.org:8080/#/c/15065/1/tests/custom_cluster/test_mt_dop.py@54
PS1, Line 54:
flake8: E203 whitespace before ':'
--
To view, visit http://gerrit.cloudera.org:8080/15065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a55a9d4ac9e0d93cb3675dd2d5da086cb7d941d
Gerrit-Change-Number: 15065
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jan 2020 18:07:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9302: disable ineffective filters for mt dop > 0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15065 )
Change subject: IMPALA-9302: disable ineffective filters for mt_dop > 0
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a55a9d4ac9e0d93cb3675dd2d5da086cb7d941d
Gerrit-Change-Number: 15065
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jan 2020 23:22:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9302: disable ineffective filters for mt dop > 0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15065 )
Change subject: IMPALA-9302: disable ineffective filters for mt_dop > 0
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5434/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/15065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a55a9d4ac9e0d93cb3675dd2d5da086cb7d941d
Gerrit-Change-Number: 15065
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jan 2020 18:07:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9302: disable ineffective filters for mt dop > 0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15065 )
Change subject: IMPALA-9302: disable ineffective filters for mt_dop > 0
......................................................................
IMPALA-9302: disable ineffective filters for mt_dop > 0
The optimisation of disabling ineffective row-level
runtime filters was not implemented in the MT scan
code paths, because the ProcessSplit() functions,
where it was implemented, are not used for mt_dop > 0.
This change adds it to HdfsScanner::GetNext(), which
is used for mt_dop > 0 but not mt_dop = 0.
Testing:
Run existing runtime row filters test with mt_dop.
This reproduced the issue before I fixed it.
Change-Id: I8a55a9d4ac9e0d93cb3675dd2d5da086cb7d941d
Reviewed-on: http://gerrit.cloudera.org:8080/15065
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/hdfs-scanner.h
M tests/custom_cluster/test_mt_dop.py
2 files changed, 13 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a55a9d4ac9e0d93cb3675dd2d5da086cb7d941d
Gerrit-Change-Number: 15065
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9302: disable ineffective filters for mt dop > 0
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15065 )
Change subject: IMPALA-9302: disable ineffective filters for mt_dop > 0
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a55a9d4ac9e0d93cb3675dd2d5da086cb7d941d
Gerrit-Change-Number: 15065
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jan 2020 18:58:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9302: disable ineffective filters for mt dop > 0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15065 )
Change subject: IMPALA-9302: disable ineffective filters for mt_dop > 0
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a55a9d4ac9e0d93cb3675dd2d5da086cb7d941d
Gerrit-Change-Number: 15065
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jan 2020 19:06:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9302: disable ineffective filters for mt dop > 0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15065 )
Change subject: IMPALA-9302: disable ineffective filters for mt_dop > 0
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5462/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a55a9d4ac9e0d93cb3675dd2d5da086cb7d941d
Gerrit-Change-Number: 15065
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jan 2020 21:18:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9302: disable ineffective filters for mt dop > 0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15065 )
Change subject: IMPALA-9302: disable ineffective filters for mt_dop > 0
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5437/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a55a9d4ac9e0d93cb3675dd2d5da086cb7d941d
Gerrit-Change-Number: 15065
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jan 2020 19:06:02 +0000
Gerrit-HasComments: No