You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/15 17:33:19 UTC
[GitHub] [airflow] uranusjr opened a new pull request #20322: Un-ignore DeprecationWarning
uranusjr opened a new pull request #20322:
URL: https://github.com/apache/airflow/pull/20322
FOR TESTING. DO NOT MERGE OR CLOSE.
These unfortunately disabled the strict error flag I set for `AirflowContextDeprecationWarning` (which is a subclass of `DeprecationWarning`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #20322: Un-ignore DeprecationWarning
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #20322:
URL: https://github.com/apache/airflow/pull/20322#issuecomment-995017776
No worries. We won't close it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #20322: Un-ignore DeprecationWarning
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #20322:
URL: https://github.com/apache/airflow/pull/20322#issuecomment-995161246
Yeah, failed at 50 (the max failures we've specified) in the "Other" tests :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #20322: Un-ignore DeprecationWarning
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #20322:
URL: https://github.com/apache/airflow/pull/20322#issuecomment-996673409
Rebased on remove changes separated to #20376.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #20322: Un-ignore DeprecationWarning
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #20322:
URL: https://github.com/apache/airflow/pull/20322#issuecomment-996618322
Alright this is working. I’m going to split the typing changes into a separate PR (that can likely be merged quickly) and rebase the rest on top of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #20322: Un-ignore DeprecationWarning
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #20322:
URL: https://github.com/apache/airflow/pull/20322#issuecomment-999060980
> Have we removed the warning filter from the ci cmdline?
Yup, following lines:
https://github.com/apache/airflow/pull/20322/files#diff-2842250bc6a0d7e30eb42ac963e84bfd12f539deecae7a32cbceb822072004d1L91-L92
https://github.com/apache/airflow/pull/20322/files#diff-5065ee052490983e4d24e039cdb0e69cfa41bd888d76e34158f3fcd7745884fbL55-L58
https://github.com/apache/airflow/pull/20322/files#diff-151019099cd27d494b3a1cfb15fb8121ba3c7c4bc442818b2e2b070aaeb57d52L210-L211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20322: Un-ignore DeprecationWarning
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20322:
URL: https://github.com/apache/airflow/pull/20322#issuecomment-998244432
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20322: Un-ignore DeprecationWarning
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20322:
URL: https://github.com/apache/airflow/pull/20322#issuecomment-995017776
No worries. We on't close it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #20322: Un-ignore DeprecationWarning
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #20322:
URL: https://github.com/apache/airflow/pull/20322#discussion_r770958858
##########
File path: airflow/utils/context.py
##########
@@ -191,7 +191,14 @@ def items(self):
def values(self):
return ValuesView(self._context)
- def copy_only(self, keys: Container[str]) -> "Context":
- new = type(self)({k: v for k, v in self._context.items() if k in keys})
- new._deprecation_replacements = self._deprecation_replacements.copy()
- return new
+
+def context_copy_partial(source: Context, keys: Container[str]) -> "Context":
+ """Create a context by copying items under selected keys in ``source``.
+
+ This is implemented as a free function because the ``Context`` type is
+ "faked" as a ``TypedDict`` in ``context.pyi``, which cannot have custom
+ functions.
Review comment:
```suggestion
functions.
:meta private:
```
as we probably don't want this to be part of the "public API".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #20322: Un-ignore DeprecationWarning
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #20322:
URL: https://github.com/apache/airflow/pull/20322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr edited a comment on pull request #20322: Un-ignore DeprecationWarning
Posted by GitBox <gi...@apache.org>.
uranusjr edited a comment on pull request #20322:
URL: https://github.com/apache/airflow/pull/20322#issuecomment-996673409
Rebased on remove changes separated to #20376. I edited the original PR description to add details on the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #20322: Un-ignore DeprecationWarning
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #20322:
URL: https://github.com/apache/airflow/pull/20322#issuecomment-997982222
Can I get some reviews on this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org