You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/17 01:21:26 UTC
Review Request 67938: Made gRPC call options configurable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67938/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-9055
https://issues.apache.org/jira/browse/MESOS-9055
Repository: mesos
Description
-------
Made gRPC call options configurable.
Diffs
-----
3rdparty/libprocess/include/process/grpc.hpp 0ff8184791277ed02b30481b352be60f10743428
3rdparty/libprocess/src/tests/grpc_tests.cpp eb9621b674ebbeda0b264001e5100a49a217629b
Diff: https://reviews.apache.org/r/67938/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 67938: Made gRPC call options configurable.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67938/#review206147
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/include/process/grpc.hpp
Lines 119 (patched)
<https://reviews.apache.org/r/67938/#comment289047>
Since this is a pure data container class `s/class/struct/`.
Then we can also drop the `public` below.
3rdparty/libprocess/include/process/grpc.hpp
Lines 122-123 (patched)
<https://reviews.apache.org/r/67938/#comment289048>
Could we add some documentation on the approximate semantics of these options, and possible how we got to these defaults?
3rdparty/libprocess/include/process/grpc.hpp
Lines 175 (patched)
<https://reviews.apache.org/r/67938/#comment289049>
Let's either pass a `const Option<CallOptions>& = None()` here, or (since this is only used in `src/csi/client.cpp` and tests) probably even better get rid of the default arg and require users to always pass in parameters.
3rdparty/libprocess/src/tests/grpc_tests.cpp
Lines 115 (patched)
<https://reviews.apache.org/r/67938/#comment289050>
This could be a `static` method.
- Benjamin Bannier
On July 17, 2018, 3:27 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67938/
> -----------------------------------------------------------
>
> (Updated July 17, 2018, 3:27 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-9055
> https://issues.apache.org/jira/browse/MESOS-9055
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made gRPC call options configurable.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/grpc.hpp 0ff8184791277ed02b30481b352be60f10743428
> 3rdparty/libprocess/src/tests/grpc_tests.cpp eb9621b674ebbeda0b264001e5100a49a217629b
>
>
> Diff: https://reviews.apache.org/r/67938/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67938: Made gRPC call options configurable.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67938/
-----------------------------------------------------------
(Updated July 17, 2018, 8:20 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Addressed Benjamin's comments.
Bugs: MESOS-9055
https://issues.apache.org/jira/browse/MESOS-9055
Repository: mesos
Description
-------
Made gRPC call options configurable.
Diffs (updated)
-----
3rdparty/libprocess/include/process/grpc.hpp 0ff8184791277ed02b30481b352be60f10743428
3rdparty/libprocess/src/tests/grpc_tests.cpp eb9621b674ebbeda0b264001e5100a49a217629b
Diff: https://reviews.apache.org/r/67938/diff/3/
Changes: https://reviews.apache.org/r/67938/diff/2-3/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 67938: Made gRPC call options configurable.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67938/#review206146
-----------------------------------------------------------
PASS: Mesos patch 67938 was successfully built and tested.
Reviews applied: `['67938']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1940/mesos-review-67938
- Mesos Reviewbot Windows
On July 17, 2018, 1:27 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67938/
> -----------------------------------------------------------
>
> (Updated July 17, 2018, 1:27 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-9055
> https://issues.apache.org/jira/browse/MESOS-9055
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made gRPC call options configurable.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/grpc.hpp 0ff8184791277ed02b30481b352be60f10743428
> 3rdparty/libprocess/src/tests/grpc_tests.cpp eb9621b674ebbeda0b264001e5100a49a217629b
>
>
> Diff: https://reviews.apache.org/r/67938/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67938: Made gRPC call options configurable.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67938/
-----------------------------------------------------------
(Updated July 17, 2018, 1:27 a.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Bugs: MESOS-9055
https://issues.apache.org/jira/browse/MESOS-9055
Repository: mesos
Description
-------
Made gRPC call options configurable.
Diffs (updated)
-----
3rdparty/libprocess/include/process/grpc.hpp 0ff8184791277ed02b30481b352be60f10743428
3rdparty/libprocess/src/tests/grpc_tests.cpp eb9621b674ebbeda0b264001e5100a49a217629b
Diff: https://reviews.apache.org/r/67938/diff/2/
Changes: https://reviews.apache.org/r/67938/diff/1-2/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao