You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/03/17 16:55:35 UTC

[GitHub] [ignite] nizhikov opened a new pull request #7542: IGNITE-12768: MetricRegistryMBean doesn't show histogram values in case when histogram name contains underscore character

nizhikov opened a new pull request #7542: IGNITE-12768: MetricRegistryMBean doesn't show histogram values in case when histogram name contains underscore character
URL: https://github.com/apache/ignite/pull/7542
 
 
   …se when histogram name contains underscore character

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] nizhikov merged pull request #7542: IGNITE-12768: MetricRegistryMBean doesn't show histogram values in case when histogram name contains underscore character

Posted by GitBox <gi...@apache.org>.
nizhikov merged pull request #7542: IGNITE-12768: MetricRegistryMBean doesn't show histogram values in case when histogram name contains underscore character
URL: https://github.com/apache/ignite/pull/7542
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] nizhikov commented on a change in pull request #7542: IGNITE-12768: MetricRegistryMBean doesn't show histogram values in case when histogram name contains underscore character

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #7542: IGNITE-12768: MetricRegistryMBean doesn't show histogram values in case when histogram name contains underscore character
URL: https://github.com/apache/ignite/pull/7542#discussion_r394193057
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/spi/metric/jmx/MetricRegistryMBean.java
 ##########
 @@ -155,12 +155,26 @@ else if (metric instanceof ObjectMetric)
      * @see MetricUtils#histogramBucketNames(HistogramMetric, Map)
      */
     public static Long searchHistogram(String name, ReadOnlyMetricRegistry mreg) {
-        Scanner sc = new Scanner(name).useDelimiter("_");
+        int highBoundIdx;
 
-        if (!sc.hasNext())
+        boolean isInf = name.endsWith(INF);
+
+        if (isInf) {
 
 Review comment:
   fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] NSAmelchev commented on a change in pull request #7542: IGNITE-12768: MetricRegistryMBean doesn't show histogram values in case when histogram name contains underscore character

Posted by GitBox <gi...@apache.org>.
NSAmelchev commented on a change in pull request #7542: IGNITE-12768: MetricRegistryMBean doesn't show histogram values in case when histogram name contains underscore character
URL: https://github.com/apache/ignite/pull/7542#discussion_r394184956
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/spi/metric/jmx/MetricRegistryMBean.java
 ##########
 @@ -155,12 +155,26 @@ else if (metric instanceof ObjectMetric)
      * @see MetricUtils#histogramBucketNames(HistogramMetric, Map)
      */
     public static Long searchHistogram(String name, ReadOnlyMetricRegistry mreg) {
-        Scanner sc = new Scanner(name).useDelimiter("_");
+        int highBoundIdx;
 
-        if (!sc.hasNext())
+        boolean isInf = name.endsWith(INF);
+
+        if (isInf) {
 
 Review comment:
   Unnecessary brackets

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services