You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:54:30 UTC

[GitHub] [nifi] sylmorin-gbif opened a new pull request #4440: NIFI-528 add support to specify timeout in ExecuteProcess

sylmorin-gbif opened a new pull request #4440:
URL: https://github.com/apache/nifi/pull/4440


   From the unfinished PR #1755 by @medjessy
   
   Fixing the indentation issues as requested in PR comments


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] pvillard31 commented on a change in pull request #4440: NIFI-528 add support to specify timeout in ExecuteProcess

Posted by GitBox <gi...@apache.org>.
pvillard31 commented on a change in pull request #4440:
URL: https://github.com/apache/nifi/pull/4440#discussion_r462823173



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteProcess.java
##########
@@ -263,10 +287,14 @@ public void process(final OutputStream flowFileOut) throws IOException {
                         // NB!!! Maybe get(long timeout, TimeUnit unit) should
                         // be used to avoid waiting forever.

Review comment:
       I guess this should be removed now, no? (or al least changed to something explaining the timeout)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] github-actions[bot] commented on pull request #4440: NIFI-528 add support to specify timeout in ExecuteProcess

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #4440:
URL: https://github.com/apache/nifi/pull/4440#issuecomment-826170722


   We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable.  If you would like this PR re-opened you can do so and a committer can remove the stale tag.  Or you can open a new PR.  Try to help review other PRs to increase PR review bandwidth which in turn helps yours.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] github-actions[bot] closed pull request #4440: NIFI-528 add support to specify timeout in ExecuteProcess

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #4440:
URL: https://github.com/apache/nifi/pull/4440


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] github-actions[bot] commented on pull request #4440: NIFI-528 add support to specify timeout in ExecuteProcess

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #4440:
URL: https://github.com/apache/nifi/pull/4440#issuecomment-826170722


   We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable.  If you would like this PR re-opened you can do so and a committer can remove the stale tag.  Or you can open a new PR.  Try to help review other PRs to increase PR review bandwidth which in turn helps yours.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org