[GitHub] dukescript commented on issue #917: WIP: Fragments for libs.javafx with JavaFX 11 implementation

[GitBox <gi...@apache.org>]

dukescript commented on issue #917: WIP: Fragments for libs.javafx with JavaFX 11 implementation
URL: https://github.com/apache/incubator-netbeans/pull/917#issuecomment-426493151
 
 
   > So, I think this is a great idea - but the patch is adding the libraries to the
   > standard (platform) build, no? 
   > While I would appreciate that, this does not seem to be allowed per 
   > Apache rules due to the license?
   
   Right. The modules cannot be part of regular distribution. They need to be downloaded on demand. On the other hand, the NBMs could be hosted on Apache AU, as 4a7f7ba changes the NBMs to not contain the actual JAR files -only to download the JARs from Maven repository.
   
   > I agree with Jan, great idea, but we will not be able to produce/use the 
   > binaries here at apache - so we need a similar solution to Jan's nbjavac.
   
   The 4a7f7ba approach is similar to `nbjavac` one, moreover it avoids the need to host anything outside of Apache and Maven download locations.
   
   > Concerning the OS dependency, could
   >
   > OpenIDE-Module-Requires: org.openide.modules.os.Windows
   > OpenIDE-Module-Requires: org.openide.modules.os.PlainUnix 
   > OpenIDE-Module-Requires: org.openide.modules.os.MacOSX
   > help?
   
   I am not sure I understand the comment. There is `OpenIDE-Module-Needs` in each of the module manifests with almost identical behavior to `OpenIDE-Module-Requires`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists