You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2017/02/01 18:09:12 UTC
Review Request 56182: ATLAS-1516: fix unit test failure in
DefaultMetadataServiceTest.testSpecialCharacters()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56182/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1516
https://issues.apache.org/jira/browse/ATLAS-1516
Repository: atlas
Description
-------
There were couple of issues:
- the test used Json-ified strings to compare 2 Referenceable objects - which failed sometime due to Json strings having different order of map entries of Referenceable values. Test was updated to use Referenceable.equals() to compare the objects
- array type attribute in one Referenceable was String[], while the other had List<String>. This resulted in comparision failure. Test was updated to replace use of String[] with List<String>
Diffs
-----
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java aa1cdaa
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 401df5f
Diff: https://reviews.apache.org/r/56182/diff/
Testing
-------
- ran the updated unit test a number of times and verified that it passes
Thanks,
Madhan Neethiraj
Re: Review Request 56182: ATLAS-1516: fix unit test failure in
DefaultMetadataServiceTest.testSpecialCharacters()
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56182/#review163845
-----------------------------------------------------------
Ship it!
Ship It!
- Apoorv Naik
On Feb. 1, 2017, 6:09 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56182/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 6:09 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1516
> https://issues.apache.org/jira/browse/ATLAS-1516
>
>
> Repository: atlas
>
>
> Description
> -------
>
> There were couple of issues:
> - the test used Json-ified strings to compare 2 Referenceable objects - which failed sometime due to Json strings having different order of map entries of Referenceable values. Test was updated to use Referenceable.equals() to compare the objects
> - array type attribute in one Referenceable was String[], while the other had List<String>. This resulted in comparision failure. Test was updated to replace use of String[] with List<String>
>
>
> Diffs
> -----
>
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java aa1cdaa
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 401df5f
>
> Diff: https://reviews.apache.org/r/56182/diff/
>
>
> Testing
> -------
>
> - ran the updated unit test a number of times and verified that it passes
>
>
> Thanks,
>
> Madhan Neethiraj
>
>