You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/24 19:13:21 UTC
[GitHub] flink pull request #3983: [FLINK-6688] Activate strict checkstyle for flink-...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3983
[FLINK-6688] Activate strict checkstyle for flink-test-utils
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6688_checkstyle_tutils
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3983.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3983
----
commit 8510be59f858ec0b024a1a8b9890977d23f7782a
Author: zentol <ch...@apache.org>
Date: 2017-05-23T19:11:38Z
[FLINK-6691][checkstyle] Add separate block for scala imports
commit 49b8c357508859ed5a92e2b10f9d3ac3ce3092b8
Author: zentol <ch...@apache.org>
Date: 2017-05-24T19:10:33Z
[FLINK-6688] Activate strict checkstyle for flink-test-utils
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3983: [FLINK-6688] Activate strict checkstyle for flink-test-ut...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3983
Merging, the problem was that i set a `@ClassRule` `TemporaryFolder` to non-public...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3983: [FLINK-6688] Activate strict checkstyle for flink-...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3983
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3983: [FLINK-6688] Activate strict checkstyle for flink-test-ut...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3983
+1 if Travis
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3983: [FLINK-6688] Activate strict checkstyle for flink-test-ut...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3983
What...something weird is going on. For some reason i get checkstyle errors on travis in hadoop-compat and flink-tests, but they shouldn't be affected O.o
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---