You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2025/09/27 03:17:03 UTC

[PR] Fix flaky test in cluster failover [kvrocks-controller]

git-hulk opened a new pull request, #355:
URL: https://github.com/apache/kvrocks-controller/pull/355

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flaky test in cluster failover [kvrocks-controller]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #355:
URL: https://github.com/apache/kvrocks-controller/pull/355#issuecomment-3341106982

   ## [Codecov](https://app.codecov.io/gh/apache/kvrocks-controller/pull/355?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 47.07%. Comparing base ([`6c56470`](https://app.codecov.io/gh/apache/kvrocks-controller/commit/6c564700d621ef30a182bad1bfeff0aa13db6ea7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6d66216`](https://app.codecov.io/gh/apache/kvrocks-controller/commit/6d66216ad0813140e4b7c104d37784a0d353c6b9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 88 commits behind head on unstable.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##           unstable     #355      +/-   ##
   ============================================
   + Coverage     43.38%   47.07%   +3.69%     
   ============================================
     Files            37       45       +8     
     Lines          2971     4452    +1481     
   ============================================
   + Hits           1289     2096     +807     
   - Misses         1544     2144     +600     
   - Partials        138      212      +74     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/kvrocks-controller/pull/355/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [unittests](https://app.codecov.io/gh/apache/kvrocks-controller/pull/355/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.07% <ø> (+3.69%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kvrocks-controller/pull/355?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flaky test in cluster failover [kvrocks-controller]

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk merged PR #355:
URL: https://github.com/apache/kvrocks-controller/pull/355


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flaky test in cluster failover [kvrocks-controller]

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #355:
URL: https://github.com/apache/kvrocks-controller/pull/355#issuecomment-3341286308

   It still has the flaky condition after the last fix. The root cause is that multiple test cases are sharing the same kvrocks cluster, and their migration status will affect each other. I have rerun it a few times, and it should be stable after this fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flaky test in cluster failover [kvrocks-controller]

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #355:
URL: https://github.com/apache/kvrocks-controller/pull/355#issuecomment-3341287852

   @PragmaTwice Thanks for your prompt review. Another issue to be improved is that `cluster.Reset()` should first flush the master node and then reset the other replicas. Or it may fail to reset replicas because some data is left inside the instance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org