[GitHub] [brooklyn-server] algairim commented on a diff in pull request #1339: Support arrays in string constraint parser

[GitBox <gi...@apache.org>]

algairim commented on code in PR #1339:
URL: https://github.com/apache/brooklyn-server/pull/1339#discussion_r920997035


##########
core/src/main/java/org/apache/brooklyn/core/objs/ConstraintSerialization.java:
##########
@@ -333,7 +337,10 @@ public Predicate<?> toPredicateFromJson(Object o) {
             if (key.indexOf("(")>=0) {
                 // it wasn't json; delegate to the parser again
                 StringConstraintParser parser = StringConstraintParser.forConstraint(this, key);
-                if (!parser.parse()) throw new IllegalStateException("cannot match: "+key);
+                if (!parser.parse()) {
+                    Object a = parser.result;

Review Comment:
   There is a garbage I left from debugging, @ahgittin.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org