[jira] [Commented] (FLINK-9859) Distinguish TM akka config with JM config

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545028#comment-16545028 ] 

ASF GitHub Bot commented on FLINK-9859:
---------------------------------------

GitHub user tison1 opened a pull request:

    https://github.com/apache/flink/pull/6339

    [FLINK-9859][Runtime] Distinguish TM akka config with JM config

    ## What is the purpose of the change
    
     Distinguish TM akka config with JM config.
    
     1. increase the number of akka threads on JM, to improve its performance
     2. decrease the number of akka threads on TM, to save resource.
    
    
    ## Brief change log
      - `AkkaUtils`
        - add a method `getTaskExecutorAkkaConfig` to distinguish TM's config with JM's
        - also the config details
      - `TaskManagerRunner` && `AkkaRpcServiceUtils` && `AkkaOptions`
        - add a method `AkkaRpcServiceUtils#createRpcServiceForTaskExecutor`
        - add a config option `AkkaOptions#AKKA_PORT_BIND_TIMEOUT`, which defines the timeout of binding retry. This is used in `AkkaRpcServiceUtils#createRpcServiceForTaskExecutor`
        - `TaskManagerRunner#createRpcService` now uses `AkkaRpcServiceUtils#createRpcServiceForTaskExecutor` to create RpcService
      - add a test `AkkaRpcServiceUtilsTest` to see createRpcService works after changes above
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - Unit test. Locally create rpc service using customized config, to see whether we could createRpcService properly.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no, it is internal)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tison1/flink akka-improve

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6339.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6339
    
----
commit 019c018dfa994b6ef755823658adf613166659c8
Author: 陈梓立 <wa...@...>
Date:   2018-07-16T09:47:29Z

    [FLINK-9859][Runtime] Distinguish TM akka config with JM config
    
    ... increase the number of akka threads on JM, to improve its performance; decrease the number of akka threads on TM, to save resource.

----


> Distinguish TM akka config with JM config
> -----------------------------------------
>
>                 Key: FLINK-9859
>                 URL: https://issues.apache.org/jira/browse/FLINK-9859
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>    Affects Versions: 1.5.1
>            Reporter: 陈梓立
>            Assignee: 陈梓立
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.5.2
>
>
> ... increase the number of akka threads on JM, to improve its performance; decrease the number of akka threads on TM, to save resource.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)