You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Tanya-W (via GitHub)" <gi...@apache.org> on 2023/01/28 09:02:10 UTC
[GitHub] [doris] Tanya-W opened a new pull request, #16161: [fix](inverted index) fulltext match query should not prune by zone map
Tanya-W opened a new pull request, #16161:
URL: https://github.com/apache/doris/pull/16161
# Proposed changes
zone map prune data by min/max value, should not prune by zone map when fulltext match term is substring in a string type column's value, otherwise, some data meeting the conditions will be pruned.
such like:
- test data:
| col_1 |
| ---- |
| hello world |
| say hello world |
| zero |
- match query:
```
select * from tb where col_1 match 'world';
```
`hello world` and `say hello world` should be returned to the user instead of being pruned by zone map.
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Tanya-W closed pull request #16161: [fix](inverted index) fulltext match query should not prune by zone map
Posted by "Tanya-W (via GitHub)" <gi...@apache.org>.
Tanya-W closed pull request #16161: [fix](inverted index) fulltext match query should not prune by zone map
URL: https://github.com/apache/doris/pull/16161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16161: [fix](inverted index) fulltext match query should not prune by zone map
Posted by github-actions.
github-actions[bot] commented on PR #16161:
URL: https://github.com/apache/doris/pull/16161#issuecomment-1407346107
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16161: [fix](inverted index) fulltext match query should not prune by zone map
Posted by github-actions.
github-actions[bot] commented on PR #16161:
URL: https://github.com/apache/doris/pull/16161#issuecomment-1407346437
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16161: [fix](inverted index) fulltext match query should not prune by zone map
Posted by github-actions.
github-actions[bot] commented on PR #16161:
URL: https://github.com/apache/doris/pull/16161#issuecomment-1407377323
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16161: [fix](inverted index) fulltext match query should not prune by zone map
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #16161:
URL: https://github.com/apache/doris/pull/16161#issuecomment-1407376959
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.29 seconds
load time: 539 seconds
storage size: 17122430817 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230128111713_clickbench_pr_85584.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] airborne12 commented on a diff in pull request #16161: [fix](inverted index) fulltext match query should not prune by zone map
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on code in PR #16161:
URL: https://github.com/apache/doris/pull/16161#discussion_r1089842568
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -367,6 +367,12 @@ Status SegmentIterator::_get_row_ranges_from_conditions(RowRanges* condition_row
RowRanges zone_map_row_ranges = RowRanges::create_single(num_rows());
// second filter data by zone map
for (auto& cid : cids) {
+ if (_inverted_index_iterators[_schema.unique_id(cid)] != nullptr &&
Review Comment:
may be we can use the same logic above to tell whether it's a fulltext match query or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org