You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/11 01:14:10 UTC

[GitHub] [airflow-site] mik-laj opened a new pull request #349: Sync version between release and package

mik-laj opened a new pull request #349:
URL: https://github.com/apache/airflow-site/pull/349


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow-site] mik-laj merged pull request #349: Sync version between release and package

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #349:
URL: https://github.com/apache/airflow-site/pull/349


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow-site] ashb commented on a change in pull request #349: Sync version between release and package

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #349:
URL: https://github.com/apache/airflow-site/pull/349#discussion_r540791726



##########
File path: .github/workflows/build.yml
##########
@@ -108,11 +108,13 @@ jobs:
           github.event_name == 'push'
         run: |
           gh auth status
-          gh release delete v0.0.3 -y || true
+          VERSION="$(cat setup.py | grep 'version=' | cut -d "'" -f 2)"

Review comment:
       If we are okay with "running" setup.py we can do `python setup.py --version`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow-site] mik-laj commented on a change in pull request #349: Sync version between release and package

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #349:
URL: https://github.com/apache/airflow-site/pull/349#discussion_r540867422



##########
File path: .github/workflows/build.yml
##########
@@ -108,11 +108,13 @@ jobs:
           github.event_name == 'push'
         run: |
           gh auth status
-          gh release delete v0.0.3 -y || true
+          VERSION="$(cat setup.py | grep 'version=' | cut -d "'" -f 2)"

Review comment:
       I applied your suggestion.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org