You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2020/10/18 21:42:24 UTC

[GitHub] [incubator-tuweni] atoulme opened a new pull request #157: Discv5 scrape

atoulme opened a new pull request #157:
URL: https://github.com/apache/incubator-tuweni/pull/157


   ## PR description
   Adds a discv5 scraper.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #157: Discv5 scrape

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #157:
URL: https://github.com/apache/incubator-tuweni/pull/157#issuecomment-711436562


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=h1) Report
   > Merging [#157](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/0f21d5cfe6710c1dada022c6ddf2489783801449?el=desc) will **decrease** coverage by `4.98%`.
   > The diff coverage is `9.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/157/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #157      +/-   ##
   ============================================
   - Coverage     66.20%   61.22%   -4.99%     
   + Complexity     4164     3870     -294     
   ============================================
     Files           375      351      -24     
     Lines         20058    19776     -282     
     Branches       2474     2485      +11     
   ============================================
   - Hits          13280    12108    -1172     
   - Misses         5390     6377     +987     
   + Partials       1388     1291      -97     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `?` | `?` | |
   | #unit | `61.22% <9.23%> (-0.29%)` | `3870.00 <1.00> (-3.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `0.00% <0.00%> (-5.08%)` | `0.00 <0.00> (-3.00)` | |
   | [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `49.21% <16.00%> (-39.47%)` | `0.00 <0.00> (ø)` | |
   | [...java/org/apache/tuweni/concurrent/ExpiringSet.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-Y29uY3VycmVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL2NvbmN1cnJlbnQvRXhwaXJpbmdTZXQuamF2YQ==) | `45.71% <44.44%> (-0.83%)` | `19.00 <0.00> (-1.00)` | |
   | [...otlin/org/apache/tuweni/devp2p/PeerRoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJvdXRpbmdUYWJsZS5rdA==) | `60.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `84.07% <100.00%> (-0.76%)` | `11.00 <0.00> (ø)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `77.27% <100.00%> (+3.35%)` | `8.00 <1.00> (ø)` | |
   | [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | ... and [72 more](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=footer). Last update [0f21d5c...422652a](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #157: Discv5 scrape

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #157:
URL: https://github.com/apache/incubator-tuweni/pull/157#issuecomment-711436562


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=h1) Report
   > Merging [#157](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/0f21d5cfe6710c1dada022c6ddf2489783801449?el=desc) will **decrease** coverage by `0.29%`.
   > The diff coverage is `11.53%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/157/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #157      +/-   ##
   ============================================
   - Coverage     66.20%   65.91%   -0.30%     
   + Complexity     4164     4161       -3     
   ============================================
     Files           375      376       +1     
     Lines         20058    20156      +98     
     Branches       2474     2490      +16     
   ============================================
   + Hits          13280    13285       +5     
   - Misses         5390     5482      +92     
   - Partials       1388     1389       +1     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `47.07% <8.26%> (-0.65%)` | `600.00 <0.00> (-3.00)` | |
   | #unit | `61.22% <9.23%> (-0.29%)` | `3870.00 <1.00> (-3.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `4.79% <0.00%> (-0.28%)` | `3.00 <0.00> (ø)` | |
   | [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `76.56% <28.00%> (-12.12%)` | `0.00 <0.00> (ø)` | |
   | [...java/org/apache/tuweni/concurrent/ExpiringSet.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-Y29uY3VycmVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL2NvbmN1cnJlbnQvRXhwaXJpbmdTZXQuamF2YQ==) | `45.71% <44.44%> (-0.83%)` | `19.00 <0.00> (-1.00)` | |
   | [...otlin/org/apache/tuweni/devp2p/PeerRoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJvdXRpbmdUYWJsZS5rdA==) | `60.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `84.95% <100.00%> (+0.13%)` | `11.00 <0.00> (ø)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `77.27% <100.00%> (+3.35%)` | `8.00 <1.00> (ø)` | |
   | [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `80.70% <0.00%> (-0.88%)` | `13.00% <0.00%> (-2.00%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=footer). Last update [0f21d5c...422652a](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #157: Discv5 scrape

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #157:
URL: https://github.com/apache/incubator-tuweni/pull/157#issuecomment-711436562


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=h1) Report
   > Merging [#157](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/0f21d5cfe6710c1dada022c6ddf2489783801449?el=desc) will **decrease** coverage by `19.10%`.
   > The diff coverage is `7.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/157/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master     #157       +/-   ##
   =============================================
   - Coverage     66.20%   47.10%   -19.11%     
   + Complexity     4164      601     -3563     
   =============================================
     Files           375      134      -241     
     Lines         20058     6178    -13880     
     Branches       2474      615     -1859     
   =============================================
   - Hits          13280     2910    -10370     
   + Misses         5390     3019     -2371     
   + Partials       1388      249     -1139     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `47.10% <7.50%> (-0.63%)` | `601.00 <0.00> (-2.00)` | |
   | #unit | `?` | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `4.79% <0.00%> (-0.28%)` | `3.00 <0.00> (ø)` | |
   | [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `71.09% <28.00%> (-17.59%)` | `0.00 <0.00> (ø)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `34.78% <50.00%> (-39.14%)` | `1.00 <0.00> (-7.00)` | |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `84.95% <100.00%> (+0.13%)` | `11.00 <0.00> (ø)` | |
   | [...p/src/main/kotlin/org/apache/tuweni/devp2p/Peer.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlci5rdA==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [.../main/java/org/apache/tuweni/ethstats/TxStats.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9UeFN0YXRzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...weni/scuttlebutt/handshake/HandshakeException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL0hhbmRzaGFrZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ebutt/handshake/SecureScuttlebuttStreamServer.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL1NlY3VyZVNjdXR0bGVidXR0U3RyZWFtU2VydmVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `1.00% <0.00%> (-2.00%)` | |
   | [...in/kotlin/org/apache/tuweni/devp2p/eth/Messages.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9NZXNzYWdlcy5rdA==) | `0.00% <0.00%> (-94.45%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [295 more](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=footer). Last update [0f21d5c...2d65299](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] atoulme merged pull request #157: Discv5 scrape

Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #157:
URL: https://github.com/apache/incubator-tuweni/pull/157


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #157: Discv5 scrape

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #157:
URL: https://github.com/apache/incubator-tuweni/pull/157#issuecomment-711436562


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=h1) Report
   > Merging [#157](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/0f21d5cfe6710c1dada022c6ddf2489783801449?el=desc) will **decrease** coverage by `0.27%`.
   > The diff coverage is `11.53%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/157/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #157      +/-   ##
   ============================================
   - Coverage     66.20%   65.93%   -0.28%     
   + Complexity     4164     4161       -3     
   ============================================
     Files           375      376       +1     
     Lines         20058    20156      +98     
     Branches       2474     2490      +16     
   ============================================
   + Hits          13280    13290      +10     
   - Misses         5390     5479      +89     
   + Partials       1388     1387       -1     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `46.99% <8.26%> (-0.73%)` | `600.00 <0.00> (-3.00)` | |
   | #unit | `61.27% <9.23%> (-0.25%)` | `3871.00 <1.00> (-2.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `4.79% <0.00%> (-0.28%)` | `3.00 <0.00> (ø)` | |
   | [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `76.56% <28.00%> (-12.12%)` | `0.00 <0.00> (ø)` | |
   | [...java/org/apache/tuweni/concurrent/ExpiringSet.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-Y29uY3VycmVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL2NvbmN1cnJlbnQvRXhwaXJpbmdTZXQuamF2YQ==) | `45.71% <44.44%> (-0.83%)` | `19.00 <0.00> (-1.00)` | |
   | [...otlin/org/apache/tuweni/devp2p/PeerRoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJvdXRpbmdUYWJsZS5rdA==) | `60.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `84.95% <100.00%> (+0.13%)` | `11.00 <0.00> (ø)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `77.27% <100.00%> (+3.35%)` | `8.00 <1.00> (ø)` | |
   | [...apache/tuweni/concurrent/coroutines/AsyncResult.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNSZXN1bHQua3Q=) | `81.13% <0.00%> (-3.78%)` | `0.00% <0.00%> (ø%)` | |
   | [...a/org/apache/tuweni/ethstats/EthStatsReporter.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9FdGhTdGF0c1JlcG9ydGVyLmphdmE=) | `67.58% <0.00%> (-2.76%)` | `22.00% <0.00%> (-1.00%)` | |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=footer). Last update [0f21d5c...422652a](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #157: Discv5 scrape

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #157:
URL: https://github.com/apache/incubator-tuweni/pull/157#issuecomment-711436562


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=h1) Report
   > Merging [#157](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/0f21d5cfe6710c1dada022c6ddf2489783801449?el=desc) will **decrease** coverage by `19.10%`.
   > The diff coverage is `7.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/157/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master     #157       +/-   ##
   =============================================
   - Coverage     66.20%   47.10%   -19.11%     
   + Complexity     4164      601     -3563     
   =============================================
     Files           375      134      -241     
     Lines         20058     6178    -13880     
     Branches       2474      615     -1859     
   =============================================
   - Hits          13280     2910    -10370     
   + Misses         5390     3019     -2371     
   + Partials       1388      249     -1139     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `47.10% <7.50%> (-0.63%)` | `601.00 <0.00> (-2.00)` | |
   | #unit | `?` | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `4.79% <0.00%> (-0.28%)` | `3.00 <0.00> (ø)` | |
   | [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `71.09% <28.00%> (-17.59%)` | `0.00 <0.00> (ø)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `34.78% <50.00%> (-39.14%)` | `1.00 <0.00> (-7.00)` | |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `84.95% <100.00%> (+0.13%)` | `11.00 <0.00> (ø)` | |
   | [...p/src/main/kotlin/org/apache/tuweni/devp2p/Peer.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlci5rdA==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [.../main/java/org/apache/tuweni/ethstats/TxStats.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9UeFN0YXRzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...weni/scuttlebutt/handshake/HandshakeException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL0hhbmRzaGFrZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ebutt/handshake/SecureScuttlebuttStreamServer.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL1NlY3VyZVNjdXR0bGVidXR0U3RyZWFtU2VydmVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `1.00% <0.00%> (-2.00%)` | |
   | [...in/kotlin/org/apache/tuweni/devp2p/eth/Messages.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9NZXNzYWdlcy5rdA==) | `0.00% <0.00%> (-94.45%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [295 more](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=footer). Last update [0f21d5c...70500a3](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #157: Discv5 scrape

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #157:
URL: https://github.com/apache/incubator-tuweni/pull/157#issuecomment-711436562


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=h1) Report
   > Merging [#157](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/0f21d5cfe6710c1dada022c6ddf2489783801449?el=desc) will **decrease** coverage by `4.93%`.
   > The diff coverage is `9.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/157/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #157      +/-   ##
   ============================================
   - Coverage     66.20%   61.27%   -4.94%     
   + Complexity     4164     3871     -293     
   ============================================
     Files           375      351      -24     
     Lines         20058    19776     -282     
     Branches       2474     2485      +11     
   ============================================
   - Hits          13280    12117    -1163     
   - Misses         5390     6370     +980     
   + Partials       1388     1289      -99     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `?` | `?` | |
   | #unit | `61.27% <9.23%> (-0.25%)` | `3871.00 <1.00> (-2.00)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `0.00% <0.00%> (-5.08%)` | `0.00 <0.00> (-3.00)` | |
   | [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `49.21% <16.00%> (-39.47%)` | `0.00 <0.00> (ø)` | |
   | [...java/org/apache/tuweni/concurrent/ExpiringSet.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-Y29uY3VycmVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL2NvbmN1cnJlbnQvRXhwaXJpbmdTZXQuamF2YQ==) | `45.71% <44.44%> (-0.83%)` | `19.00 <0.00> (-1.00)` | |
   | [...otlin/org/apache/tuweni/devp2p/PeerRoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJvdXRpbmdUYWJsZS5rdA==) | `60.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `84.07% <100.00%> (-0.76%)` | `11.00 <0.00> (ø)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `77.27% <100.00%> (+3.35%)` | `8.00 <1.00> (ø)` | |
   | [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | ... and [75 more](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=footer). Last update [0f21d5c...422652a](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #157: Discv5 scrape

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #157:
URL: https://github.com/apache/incubator-tuweni/pull/157#issuecomment-711436562


   # [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=h1) Report
   > Merging [#157](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/0f21d5cfe6710c1dada022c6ddf2489783801449?el=desc) will **decrease** coverage by `19.10%`.
   > The diff coverage is `7.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tuweni/pull/157/graphs/tree.svg?width=650&height=150&src=pr&token=U8STS3qOg5)](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master     #157       +/-   ##
   =============================================
   - Coverage     66.20%   47.10%   -19.11%     
   + Complexity     4164      601     -3563     
   =============================================
     Files           375      134      -241     
     Lines         20058     6178    -13880     
     Branches       2474      615     -1859     
   =============================================
   - Hits          13280     2910    -10370     
   + Misses         5390     3019     -2371     
   + Partials       1388      249     -1139     
   ```
   
   | Flag | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | #integration | `47.10% <7.50%> (-0.63%)` | `601.00 <0.00> (-2.00)` | |
   | #unit | `?` | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...main/kotlin/org/apache/tuweni/devp2p/v5/Session.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvU2Vzc2lvbi5rdA==) | `4.79% <0.00%> (-0.28%)` | `3.00 <0.00> (ø)` | |
   | [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `71.09% <28.00%> (-17.59%)` | `0.00 <0.00> (ø)` | |
   | [...kotlin/org/apache/tuweni/devp2p/v5/RoutingTable.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUm91dGluZ1RhYmxlLmt0) | `34.78% <50.00%> (-39.14%)` | `1.00 <0.00> (-7.00)` | |
   | [...in/org/apache/tuweni/devp2p/v5/HandshakeSession.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvSGFuZHNoYWtlU2Vzc2lvbi5rdA==) | `84.95% <100.00%> (+0.13%)` | `11.00 <0.00> (ø)` | |
   | [...p/src/main/kotlin/org/apache/tuweni/devp2p/Peer.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlci5rdA==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [.../main/java/org/apache/tuweni/ethstats/TxStats.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9UeFN0YXRzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...weni/scuttlebutt/handshake/HandshakeException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL0hhbmRzaGFrZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ebutt/handshake/SecureScuttlebuttStreamServer.java](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL1NlY3VyZVNjdXR0bGVidXR0U3RyZWFtU2VydmVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `1.00% <0.00%> (-2.00%)` | |
   | [...in/kotlin/org/apache/tuweni/devp2p/eth/Messages.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9NZXNzYWdlcy5rdA==) | `0.00% <0.00%> (-94.45%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [295 more](https://codecov.io/gh/apache/incubator-tuweni/pull/157/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=footer). Last update [0f21d5c...422652a](https://codecov.io/gh/apache/incubator-tuweni/pull/157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org