You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/09 11:11:20 UTC

[GitHub] [pulsar] tisonkun opened a new pull request, #16494: [sql] Upgrade prestosql to trino

tisonkun opened a new pull request, #16494:
URL: https://github.com/apache/pulsar/pull/16494

   Related to https://github.com/trinodb/trino/pull/8020.
   
   ### Motivation
   
   Catching up upstream.
   
   ### Modifications
   
   
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   - [x] `doc-required` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #16494: [sql] Upgrade prestosql to trino

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16494:
URL: https://github.com/apache/pulsar/pull/16494#issuecomment-1182864180

   Closed in favor of a PIP to move pulsar-sql to a separated repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #16494: [sql] Upgrade prestosql to trino

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #16494:
URL: https://github.com/apache/pulsar/pull/16494#issuecomment-1179892960

   FYI: we tried to contribute [guides](https://github.com/trinodb/trino/pull/8977) to Trino before


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #16494: [sql] Upgrade prestosql to trino

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #16494:
URL: https://github.com/apache/pulsar/pull/16494#issuecomment-1179893207

   FYI: we tried to contribute [guides](https://github.com/trinodb/trino/pull/8977) to Trino before
   
   cc @MarvinCai 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on a diff in pull request #16494: [sql] Upgrade prestosql to trino

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #16494:
URL: https://github.com/apache/pulsar/pull/16494#discussion_r917256820


##########
pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarSqlSchemaInfoProvider.java:
##########
@@ -6,9 +6,9 @@
  * to you under the Apache License, Version 2.0 (the
  * "License"); you may not use this file except in compliance
  * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>

Review Comment:
   ```suggestion
    *
    *   http://www.apache.org/licenses/LICENSE-2.0
    *
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun closed pull request #16494: [sql] Upgrade prestosql to trino

Posted by GitBox <gi...@apache.org>.
tisonkun closed pull request #16494: [sql] Upgrade prestosql to trino
URL: https://github.com/apache/pulsar/pull/16494


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org