[GitHub] [buildstream-plugins] gtristan commented on pull request #29: Revert "Enable setting build-dir"

[GitBox <gi...@apache.org>]

gtristan commented on PR #29:
URL: https://github.com/apache/buildstream-plugins/pull/29#issuecomment-1223601289

   I'm not sure if we should revert this.
   
   It would be nice if the built-in `command-subdir` feature worked in perfect harmony with this `build-dir` feature of `autotools` plugin, but I'm not convinced that these two working perfectly together is a blocker to adding this `build-dir` feature.
   
   It seems to me:
   * Fairly frequent that people like to use `srcdir != builddir`
   * Less frequent that we need to build something in a subdirectory
     * An odd example of building only the JS implementation from a mozilla checkout comes to mind
   * Quite improbable that we need to use `srcdir != builddir` along with `command-subdir`
     * And even then, these default build instructions are just *helpful* for covering the majority of cases, it isn't horrible that a user needs to manually override some stuff in corner cases
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org