You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Michael Bouschen (JIRA)" <ji...@apache.org> on 2015/07/31 18:55:04 UTC
[jira] [Comment Edited] (JDO-745) TCK BooleanLogicalAND,
BooleanLogicalOR testNegative don't allow an implementation to provide an
extension of bitwise AND/OR
[ https://issues.apache.org/jira/browse/JDO-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632495#comment-14632495 ]
Michael Bouschen edited comment on JDO-745 at 7/31/15 4:54 PM:
---------------------------------------------------------------
My 0,02$:
- Yes, we should have negative tests for other unsupported types.
- Yes, we should support bitwise AND/OR for intergral types.
- Yes, we should have an assertion and a tck test case that the expression must be boolean.
- Yes, we should add a negative tck test case for non-boolean expressions.
The update for tck/src/conf/log4j.properties was not intentional, I removed it from the patch.
was (Author: mbo):
My 0,02$:
- Yes, we should have negative tests for other unsupported types.
- Yes, we should support bitwise AND/OR fpr intergral types.
- Yes, we should have an assertion and a tck test case the expression must be boolean.
- Yes, we should add a negative tck test case for non-boolean expressions.
The update for tck/src/conf/log4j.properties was not intentional, I removed it from the patch.
> TCK BooleanLogicalAND, BooleanLogicalOR testNegative don't allow an implementation to provide an extension of bitwise AND/OR
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: JDO-745
> URL: https://issues.apache.org/jira/browse/JDO-745
> Project: JDO
> Issue Type: Bug
> Components: tck
> Reporter: Andy Jefferson
> Fix For: JDO 3.2
>
> Attachments: JDO-745.patch
>
>
> The tests BooleanLogicalAND.testNegative, BooleanLogicalOR.testNegative don't test use of a boolean logical AND/OR. They actually test for an integer being used with the "&" and "|" operators. Sadly this means that any implementation that attempts to provide a vendor extension of support for bitwise AND/OR (for those RDBMS that support it) cannot pass the TCK.
> Perhaps add an "optional feature" for the vendor to support bitwise operations, and then don't run that test if so.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)