You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2020/07/06 16:45:30 UTC

[httpcomponents-client] branch master updated (1572f55 -> 93e3d0f)

This is an automated email from the ASF dual-hosted git repository.

olegk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-client.git.


 discard 1572f55  HTTPCLIENT-2097: Fix PoolingAsyncClientConnectionManager boxed primitive reference equality
     new 93e3d0f  HTTPCLIENT-2097: Fix PoolingAsyncClientConnectionManager boxed primitive reference equality

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (1572f55)
            \
             N -- N -- N   refs/heads/master (93e3d0f)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


[httpcomponents-client] 01/01: HTTPCLIENT-2097: Fix PoolingAsyncClientConnectionManager boxed primitive reference equality

Posted by ol...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

olegk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-client.git

commit 93e3d0f45204836a547602c56a51f0c32f0f3df4
Author: Carter Kozak <ck...@apache.org>
AuthorDate: Sun Jul 5 13:10:25 2020 -0400

    HTTPCLIENT-2097: Fix PoolingAsyncClientConnectionManager boxed primitive reference equality
---
 .../hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
index cd0e6b0..e3a99cf 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
@@ -252,7 +252,7 @@ public class PoolingAsyncClientConnectionManager implements AsyncClientConnectio
 
                                     @Override
                                     public void execute(final Boolean result) {
-                                        if (result == Boolean.FALSE) {
+                                        if (result == null || !result)  {
                                             if (log.isDebugEnabled()) {
                                                 log.debug("{}: connection {} is stale", id, ConnPoolSupport.getId(connection));
                                             }