You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/08/03 01:58:43 UTC

[GitHub] [incubator-yunikorn-k8shim] ronazhan commented on a change in pull request #292: [YUNIKORN-744]Call healthcheck REST API in e2e tests

ronazhan commented on a change in pull request #292:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/292#discussion_r681378383



##########
File path: test/e2e/framework/helpers/yunikorn/rest_api_utils.go
##########
@@ -224,6 +224,17 @@ func isRootSched(policy string) wait.ConditionFunc {
 	}
 }
 
+func GetHealthCheck() (dao.SchedulerHealthDAOInfo, error) {
+	restClient := RClient{}

Review comment:
       The rest calls are generally designed as methods on the type RClient. See [GetApps()](https://github.com/apache/incubator-yunikorn-k8shim/blob/4d28705e4723c27178c7f8d31751ecea2150398d/test/e2e/framework/helpers/yunikorn/rest_api_utils.go#L126), or most other methods in the rest_api_utils.go for an example




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org