You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Artem Shutak (JIRA)" <ji...@apache.org> on 2015/09/30 12:50:04 UTC

[jira] [Comment Edited] (IGNITE-1559) Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner.

    [ https://issues.apache.org/jira/browse/IGNITE-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936699#comment-14936699 ] 

Artem Shutak edited comment on IGNITE-1559 at 9/30/15 10:49 AM:
----------------------------------------------------------------

Updated both: readme.io and javadocs.

Readme.io has been updated according to Yakov comments at email (see below). Please, review "Code example" part again.

>From Yakov's email:
-----------------------------------------------------------------------------------
1. SPI parameters explanations and code example should be before scanners
(scanner is SPI config as well, just more detailed info)
2. code example should include all scanners + add spring configuration
example
3.
>> quot
Http Uri Example
The following example will scan ignite/deployment folder on site
www.mysite.com using authentication 'username:password' every '10000'
milliseconds.
http://username:password;freq=10000@www.mysite.com:110/ignite/deployment
>>/quot

I thought this scanner will download the page served by a server and
mysite.com:110 (that will be default page), parse it and download and
deploy all GAR files specified by href attributes of <a> elements on the
page. Please correct your content if you agree.
-----------------------------------------------------------------------------------


was (Author: ashutak):
Updated both: readme.io and javadocs.

Readme.io has been updated according to Yakov comments at email (see below). Please, review "Code example" part again.

>From Yakov's email:
1. SPI parameters explanations and code example should be before scanners
(scanner is SPI config as well, just more detailed info)
2. code example should include all scanners + add spring configuration
example
3.
>> quot
Http Uri Example
The following example will scan ignite/deployment folder on site
www.mysite.com using authentication 'username:password' every '10000'
milliseconds.
http://username:password;freq=10000@www.mysite.com:110/ignite/deployment
>>/quot

I thought this scanner will download the page served by a server and
mysite.com:110 (that will be default page), parse it and download and
deploy all GAR files specified by href attributes of <a> elements on the
page. Please correct your content if you agree.

> Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner.
> -----------------------------------------------------------------------------
>
>                 Key: IGNITE-1559
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1559
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Artem Shutak
>            Assignee: Valentin Kulichenko
>             Fix For: ignite-1.5
>
>
> Need to improve tests, javadoc and documentation of UriDeploymentHttpScanner. It's not possible to understand from current javadoc of UriDeploymentHttpScanner how it works.
> There's only one simple test in GridHttpDeploymentSelfTest.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)