You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/04 14:07:08 UTC
[GitHub] [airflow] Junnplus opened a new pull request #13459: Add conditional to ingress apiVersion for compatibility
Junnplus opened a new pull request #13459:
URL: https://github.com/apache/airflow/pull/13459
Add conditional to ingress apiVersion for compatibility.
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13459: Add conditional to ingress apiVersion for compatibility
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13459:
URL: https://github.com/apache/airflow/pull/13459#issuecomment-754049958
Here we discussed to change that and support Kubernetes 1.14+
https://github.com/apache/airflow/pull/12619/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed pull request #13459: Add conditional to ingress apiVersion for compatibility
Posted by GitBox <gi...@apache.org>.
ashb closed pull request #13459:
URL: https://github.com/apache/airflow/pull/13459
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13459: Add conditional to ingress apiVersion for compatibility
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13459:
URL: https://github.com/apache/airflow/pull/13459#issuecomment-754018721
Here is information about supported Kubernetes versions.
> Kubernetes 1.12+ cluster
https://github.com/apache/airflow/tree/master/chart#prerequisites
All files are also verified against the Kubernetes specification.
https://github.com/apache/airflow/blob/3341d210cd265b51175d8f575e2ee73aa247f28b/chart/tests/helm_template_generator.py#L32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Junnplus edited a comment on pull request #13459: Add conditional to ingress apiVersion for compatibility
Posted by GitBox <gi...@apache.org>.
Junnplus edited a comment on pull request #13459:
URL: https://github.com/apache/airflow/pull/13459#issuecomment-754028577
@ashb thanks you for review, I used 1.11.5 on production,
I think 1.12.9+ should be compatible with `extensions/v1beta1` https://github.com/instrumenta/kubernetes-json-schema/blob/master/v1.12.9/ingress-extensions-v1beta1.json#L11 @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #13459: Add conditional to ingress apiVersion for compatibility
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #13459:
URL: https://github.com/apache/airflow/pull/13459#issuecomment-754546453
I've merged #12619 which changes the minimum requirement to Kube 1.14 so I think we close this issue now. Sorry -- 1.11 is too old for us to support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Junnplus commented on pull request #13459: Add conditional to ingress apiVersion for compatibility
Posted by GitBox <gi...@apache.org>.
Junnplus commented on pull request #13459:
URL: https://github.com/apache/airflow/pull/13459#issuecomment-754054083
@mik-laj https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/ see this blog of official
```
The v1.22 release will stop serving the following deprecated API versions in favor of newer and more stable API versions:
Ingress in the extensions/v1beta1 API version will no longer be served
Migrate to use the networking.k8s.io/v1beta1 API version, available since v1.14. Existing persisted data can be retrieved/updated via the new version.
```
1.14+ should also be compatibled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #13459: Add conditional to ingress apiVersion for compatibility
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #13459:
URL: https://github.com/apache/airflow/pull/13459#issuecomment-754039938
Even kube 1.12 is now _really_ old, 1.11 even more so. We should probably stop (officially) supporting that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Junnplus commented on pull request #13459: Add conditional to ingress apiVersion for compatibility
Posted by GitBox <gi...@apache.org>.
Junnplus commented on pull request #13459:
URL: https://github.com/apache/airflow/pull/13459#issuecomment-754028577
@ashb thanks you for review, I used 1.11.5 on production,
I think 12.9+ should be compatible with `extensions/v1beta1` https://github.com/instrumenta/kubernetes-json-schema/blob/master/v1.12.9/ingress-extensions-v1beta1.json#L11
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13459: Add conditional to ingress apiVersion for compatibility
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13459:
URL: https://github.com/apache/airflow/pull/13459#issuecomment-754107027
As for me, we can only support Kubernetes 1.14+, but I'm wondering if we should make additional changes. This change changes a little more code.
https://github.com/apache/airflow/pull/12619/files
I do not currently have time to look carefully and review these changes. Could you please help me with this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org