You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/12 14:10:06 UTC
[GitHub] [beam] johannaojeling opened a new pull request, #24138: [Go SDK] Increase test coverage for S3 filesystem
johannaojeling opened a new pull request, #24138:
URL: https://github.com/apache/beam/pull/24138
Introduces more tests for the S3 filesystem package, fixes #24137
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24138: [Go SDK] Increase test coverage for S3 filesystem
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24138:
URL: https://github.com/apache/beam/pull/24138#issuecomment-1312492887
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johannaojeling commented on pull request #24138: [Go SDK] Increase test coverage for S3 filesystem
Posted by GitBox <gi...@apache.org>.
johannaojeling commented on PR #24138:
URL: https://github.com/apache/beam/pull/24138#issuecomment-1312492621
R: @lostluck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #24138: [Go SDK] Increase test coverage for S3 filesystem
Posted by GitBox <gi...@apache.org>.
lostluck merged PR #24138:
URL: https://github.com/apache/beam/pull/24138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johannaojeling commented on pull request #24138: [Go SDK] Increase test coverage for S3 filesystem
Posted by GitBox <gi...@apache.org>.
johannaojeling commented on PR #24138:
URL: https://github.com/apache/beam/pull/24138#issuecomment-1312492778
I'm trying to learn good (testing) patterns in Go. If you see something that looks non-idiomatic or have any advice for best practices, please feel free to comment!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #24138: [Go SDK] Increase test coverage for S3 filesystem
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #24138:
URL: https://github.com/apache/beam/pull/24138#issuecomment-1312489624
# [Codecov](https://codecov.io/gh/apache/beam/pull/24138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24138](https://codecov.io/gh/apache/beam/pull/24138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4cea510) into [master](https://codecov.io/gh/apache/beam/commit/aa0a35dabf9c2a0d9822faff06d939d9a77a3ab6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa0a35d) will **increase** coverage by `0.14%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #24138 +/- ##
==========================================
+ Coverage 73.33% 73.48% +0.14%
==========================================
Files 714 714
Lines 96445 96445
==========================================
+ Hits 70729 70873 +144
+ Misses 24396 24249 -147
- Partials 1320 1323 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `51.44% <ø> (+0.48%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/24138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/go/pkg/beam/core/metrics/dumper.go](https://codecov.io/gh/apache/beam/pull/24138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL21ldHJpY3MvZHVtcGVyLmdv) | `49.20% <0.00%> (-4.77%)` | :arrow_down: |
| [sdks/go/pkg/beam/io/filesystem/s3/writer.go](https://codecov.io/gh/apache/beam/pull/24138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9maWxlc3lzdGVtL3MzL3dyaXRlci5nbw==) | `92.50% <0.00%> (+92.50%)` | :arrow_up: |
| [sdks/go/pkg/beam/io/filesystem/s3/s3.go](https://codecov.io/gh/apache/beam/pull/24138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9maWxlc3lzdGVtL3MzL3MzLmdv) | `98.24% <0.00%> (+96.49%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johannaojeling commented on pull request #24138: [Go SDK] Increase test coverage for S3 filesystem
Posted by GitBox <gi...@apache.org>.
johannaojeling commented on PR #24138:
URL: https://github.com/apache/beam/pull/24138#issuecomment-1314218621
> This is very well done. The necessary repetition has been abstracted as helpers, the cases are clear, coverage is clear, you've correctly got context as the first parameter for the test helpers.
>
> Thank you very much! We just need to resolve the go.mod+go.sum conflicts (a consequence of us keeping up with dependabot) and this will be merged right in.
Okay great, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org