You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2018/06/29 20:15:09 UTC
[GitHub] tinkerpop pull request #886: TINKERPOP-1987 Bump to Spark 2.3.1 and Netty 4....
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/886
TINKERPOP-1987 Bump to Spark 2.3.1 and Netty 4.1.25.Final
https://issues.apache.org/jira/browse/TINKERPOP-1987
These really needed to be bumped together because going to netty 4.1.x doesn't work nicely with Spark 2.2.x - Spark only upgraded to that version on 2.3.x.
That odd change to `gremlin-dotnet/src/Gremlin.Net/Process/Traversal/GraphTraversal.cs` is incidental - that modification is already on master and rebase doesn't seem to to want to get rid of it. Hopefully no one is too turned off by that little stain in change history - doesn't seem like a huge problem.
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1987
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/886.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #886
----
commit 07ca64e9d462a0ea496d3924953532f8b794346f
Author: Stephen Mallette <sp...@...>
Date: 2018-06-27T12:23:58Z
Bump to Spark 2.3.1 and Netty 4.1.25.Final
These really needed to be bumped together because going to netty 4.1.x doesn't work nicely with Spark 2.2.x - Spark only upgraded on 2.3.x.
----
---
[GitHub] tinkerpop issue #886: TINKERPOP-1987 Bump to Spark 2.3.1 and Netty 4.1.25.Fi...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/886
VOTE: +1
---
[GitHub] tinkerpop issue #886: TINKERPOP-1987 Bump to Spark 2.3.1 and Netty 4.1.25.Fi...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/886
not sure. I saw that and ran the build again locally the other day and had no trouble................
---
[GitHub] tinkerpop pull request #886: TINKERPOP-1987 Bump to Spark 2.3.1 and Netty 4....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/886
---
[GitHub] tinkerpop issue #886: TINKERPOP-1987 Bump to Spark 2.3.1 and Netty 4.1.25.Fi...
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/886
@spmallette any idea why the spark test is hanging in travis?
---