You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/03/15 23:24:59 UTC
Review Request: Removed filter in test event listener instead of in
destructor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9967/
-----------------------------------------------------------
Review request for mesos, Vinod Kone and Ben Mahler.
Description
-------
See summary.
Diffs
-----
src/tests/filter.hpp 1ed313cf7bcd5f5dae4de0040a12aa88d855632f
Diff: https://reviews.apache.org/r/9967/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Removed filter in test event listener instead of in
destructor.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On March 15, 2013, 11:17 p.m., Vinod Kone wrote:
> > Can you add a comment and what necessitated this change. I don't follow this change.
Added a comment.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9967/#review18008
-----------------------------------------------------------
On March 16, 2013, 12:03 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9967/
> -----------------------------------------------------------
>
> (Updated March 16, 2013, 12:03 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/filter.hpp 1ed313cf7bcd5f5dae4de0040a12aa88d855632f
>
> Diff: https://reviews.apache.org/r/9967/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Removed filter in test event listener instead of in
destructor.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9967/#review18008
-----------------------------------------------------------
Can you add a comment and what necessitated this change. I don't follow this change.
- Vinod Kone
On March 15, 2013, 10:24 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9967/
> -----------------------------------------------------------
>
> (Updated March 15, 2013, 10:24 p.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/filter.hpp 1ed313cf7bcd5f5dae4de0040a12aa88d855632f
>
> Diff: https://reviews.apache.org/r/9967/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Removed filter in test event listener instead of in
destructor.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9967/#review18018
-----------------------------------------------------------
Ship it!
src/tests/filter.hpp
<https://reviews.apache.org/r/9967/#comment38062>
ws
- Vinod Kone
On March 16, 2013, 12:03 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9967/
> -----------------------------------------------------------
>
> (Updated March 16, 2013, 12:03 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/filter.hpp 1ed313cf7bcd5f5dae4de0040a12aa88d855632f
>
> Diff: https://reviews.apache.org/r/9967/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Removed filter in test event listener instead of in
destructor.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9967/
-----------------------------------------------------------
(Updated March 16, 2013, 12:03 a.m.)
Review request for mesos, Vinod Kone and Ben Mahler.
Changes
-------
Addressed review comments.
Description
-------
See summary.
Diffs (updated)
-----
src/tests/filter.hpp 1ed313cf7bcd5f5dae4de0040a12aa88d855632f
Diff: https://reviews.apache.org/r/9967/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman