You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Chetan Sarva (JIRA)" <ji...@apache.org> on 2010/04/09 02:36:36 UTC
[jira] Created: (BUILDR-419) Exclusion patterns only work if they
contain a wildcard
Exclusion patterns only work if they contain a wildcard
-------------------------------------------------------
Key: BUILDR-419
URL: https://issues.apache.org/jira/browse/BUILDR-419
Project: Buildr
Issue Type: Bug
Components: Packaging
Affects Versions: 1.3.5, 1.4
Reporter: Chetan Sarva
Priority: Minor
Attachments: testcase.zip
When creating a WAR package, exclusion patterns without a wildcard do not work. For example:
package(:war).tap do |war|
war.path("WEB-INF/classes").tap do |path|
# path.exclude("foo.xml") # does not work
path.exclude("*.xml") # works
path.exclude("*.properties")
end
end
attached is a testcase project layout that displays the behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-419) Exclusion patterns only work if they
contain a wildcard
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme resolved BUILDR-419.
-----------------------------------
Fix Version/s: 1.4
Resolution: Fixed
I committed my changes, I could not find a way to do the job nearer to the code.
11:01:58~/w/buildr>svn ci spec/java/packaging_spec.rb lib/buildr/packaging/archive.rb CHANGELOG -m "fix for BUILDR-419 Exclusion patterns only work if they contain a wildcard"
Sending CHANGELOG
Sending lib/buildr/packaging/archive.rb
Sending spec/java/packaging_spec.rb
Transmitting file data ...
Committed revision 932775.
> Exclusion patterns only work if they contain a wildcard
> -------------------------------------------------------
>
> Key: BUILDR-419
> URL: https://issues.apache.org/jira/browse/BUILDR-419
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5, 1.4
> Reporter: Chetan Sarva
> Priority: Minor
> Fix For: 1.4
>
> Attachments: BUILDR-419.txt, testcase.zip
>
>
> When creating a WAR package, exclusion patterns without a wildcard do not work. For example:
> package(:war).tap do |war|
> war.path("WEB-INF/classes").tap do |path|
> # path.exclude("foo.xml") # does not work
> path.exclude("*.xml") # works
> path.exclude("*.properties")
> end
> end
> attached is a testcase project layout that displays the behaviour.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (BUILDR-419) Exclusion patterns only work if they
contain a wildcard
Posted by "Chetan Sarva (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chetan Sarva updated BUILDR-419:
--------------------------------
Attachment: testcase.zip
> Exclusion patterns only work if they contain a wildcard
> -------------------------------------------------------
>
> Key: BUILDR-419
> URL: https://issues.apache.org/jira/browse/BUILDR-419
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5, 1.4
> Reporter: Chetan Sarva
> Priority: Minor
> Attachments: testcase.zip
>
>
> When creating a WAR package, exclusion patterns without a wildcard do not work. For example:
> package(:war).tap do |war|
> war.path("WEB-INF/classes").tap do |path|
> # path.exclude("foo.xml") # does not work
> path.exclude("*.xml") # works
> path.exclude("*.properties")
> end
> end
> attached is a testcase project layout that displays the behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-419) Exclusion patterns only work if they
contain a wildcard
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme updated BUILDR-419:
----------------------------------
Attachment: BUILDR-419.txt
Attached a patch with specs that does the job. However my spec is not really good as it uses package(:jar) while this touches the archive spec. I am letting the patch up for review.
The change this patch introduces is that we start also looking for exclusion on destinations. It is much more natural for people to think in terms of destinations than sources, in particular when sources are $project/target/resources/foo.xml.
> Exclusion patterns only work if they contain a wildcard
> -------------------------------------------------------
>
> Key: BUILDR-419
> URL: https://issues.apache.org/jira/browse/BUILDR-419
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.5, 1.4
> Reporter: Chetan Sarva
> Priority: Minor
> Attachments: BUILDR-419.txt, testcase.zip
>
>
> When creating a WAR package, exclusion patterns without a wildcard do not work. For example:
> package(:war).tap do |war|
> war.path("WEB-INF/classes").tap do |path|
> # path.exclude("foo.xml") # does not work
> path.exclude("*.xml") # works
> path.exclude("*.properties")
> end
> end
> attached is a testcase project layout that displays the behaviour.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.